Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-widgets] Add initialSearchText prop to useGeocoderWidgetController hook #831

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

donmccurdy
Copy link
Member

@donmccurdy donmccurdy commented Jan 29, 2024

Description

Shortcut: https://app.shortcut.com/cartoteam/story/378094/search-location
[sc-378094]

Adds an 'initialSearchText' property to the 'useGeocoderWidgetController' so that Builder can initialize the text field from the ?search= URL parameter. Tested against Builder locally.

Also exports setGeocoderResult for use in Builder.

Type of change

  • Feature

Acceptance

n/a

Copy link

This pull request has been linked to Shortcut Story #378094: Search location.

@donmccurdy
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@donmccurdy donmccurdy requested a review from a team January 29, 2024 17:02
@donmccurdy donmccurdy added enhancement New feature or request builder labels Jan 29, 2024
@donmccurdy donmccurdy changed the title [widgets] Export setGeocoderResult, return setSearchText from useGeocoderWidgetController hook [react-widgets] Export setGeocoderResult, return setSearchText from useGeocoderWidgetController hook Jan 29, 2024
Copy link

github-actions bot commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7710752278

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.226%

Totals Coverage Status
Change from base Build 7710713851: 0.0%
Covered Lines: 2613
Relevant Lines: 3450

💛 - Coveralls

Copy link

github-actions bot commented Jan 29, 2024

Visit the preview URL for this PR (updated for commit c3cbfea):

https://cartodb-fb-storybook-react-dev--pr831-donmccurdy-widge-1qo5sqnu.web.app

(expires Tue, 06 Feb 2024 12:05:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@donmccurdy donmccurdy changed the title [react-widgets] Export setGeocoderResult, return setSearchText from useGeocoderWidgetController hook [react-widgets] Add initialSearchText prop to useGeocoderWidgetController hook Jan 29, 2024
@padawannn padawannn merged commit 7e8b675 into master Jan 30, 2024
1 check passed
@padawannn padawannn deleted the donmccurdy/widgets-geocoder-search-exports branch January 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants