ToggleButtonGroup component: Add support for variant and backgroundColor #824
+264
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #282036: CORE - Refactor: Toggle button - Add new "contained" variant. |
Pull Request Test Coverage Report for Build 7586184014
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 721fb01): https://cartodb-fb-storybook-react-dev--pr824-feature-toggle-c-mumoisvg.web.app (expires Fri, 26 Jan 2024 16:08:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
Josmorsot
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/282036/core-refactor-toggle-button-add-new-contained-variant
[sc-282036]
We need to create a component to extend ToggleButtonGroup, as it doesn't support variant & backgroundColor and It won't soon: mui/material-ui#23446