Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleButton & ToggleButtonGroup should accept a variant and/or color props like Button #23446

Closed
ChromeQ opened this issue Nov 8, 2020 · 2 comments
Labels
component: toggle button This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@ChromeQ
Copy link

ChromeQ commented Nov 8, 2020

I like the Toggle Group and Toggle Button abstract away some handling of the selected button, but I would like an option to make the buttons look like a regular ButtonGroup which can take a color prop to make them primary or secondary, and a variant for outline or contained etc

It makes sense to me that the Toggle Button Group should have many if not all of the same options that a ButtonGroup does, but only adds the toggle behaviour

@ChromeQ ChromeQ added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 8, 2020
@oliviertassinari oliviertassinari added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 8, 2020
@oliviertassinari oliviertassinari added the component: toggle button This is the name of the generic UI component, not the React module! label Nov 8, 2020
@ChromeQ
Copy link
Author

ChromeQ commented Nov 8, 2020

Can I at least have a reason or explanation why this is a won't fix @oliviertassinari?

@oliviertassinari
Copy link
Member

@ChromeQ The two components cover different use cases, we have been chatting a bit about the idea of merging them in the past but it never took. In this case, you can simply customize the components. There isn't a lot of value is spending time on this (vs. the others issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toggle button This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

No branches or pull requests

2 participants