Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments in theme to fix uses cases in cloud-native #553

Merged
merged 8 commits into from
Dec 20, 2022
Merged

Adjustments in theme to fix uses cases in cloud-native #553

merged 8 commits into from
Dec 20, 2022

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Dec 20, 2022 •
edited
Loading

Description

Shortcut: #268963
sc: [sc-268963]

Includes

  • IconButton svg size fix for cases where a raw svg is used instead of a react component
  • Temporary remove of maxWidth limitation In buttons until design team gets a stronger solution.
  • Default props of snackbar to meet the common use case
  • Temporary remove avatar border until get a better approach to avoid some collateral issues.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #268963: ENG - Material ui v5 upgrade in workspace-www - III (Visual review & fixes for WORKSPACE).

@vmilan vmilan marked this pull request as ready for review December 20, 2022 12:50
@vmilan vmilan requested a review from a team December 20, 2022 12:51
@vmilan vmilan merged commit 2edb413 into feature/design-system Dec 20, 2022
@vmilan vmilan deleted the feature/cloud-native-fixes branch December 20, 2022 12:54
@vmilan vmilan mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmorsot Josmorsot Josmorsot approved these changes

Assignees
No one assigned
Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmilan @Josmorsot