Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip component adapted to the new design system #551

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Chip component adapted to the new design system #551

merged 7 commits into from
Dec 15, 2022

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Dec 14, 2022

Description

Shortcut: #272673
[sc-272673]

  • Chip component with the new design system applied.
  • Added basic styles and story for Avatar component (used on Chip)
  • Defined a static path for assets in Storybook

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #272673: COMPONENTS - Basic components (Yak).

@vmilan vmilan requested a review from a team December 14, 2022 08:10
VictorVelarde
VictorVelarde approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmilan vmilan merged commit 23843ba into feature/design-system Dec 15, 2022
@vmilan vmilan deleted the feature/chips branch December 15, 2022 08:27
@vmilan vmilan mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmilan @VictorVelarde