TextField and TextArea components adapted to the new design system #538
Conversation
|
This pull request has been linked to Shortcut Story #268673: COMPONENTS - Basic components (forms). |
| <InputAdornment position='end'> | ||
| <IconButton onClick={handleClickShowPassword}> | ||
| {showPassword ? <VisibilityOutlined /> : <VisibilityOffOutlined />} | ||
| </IconButton> | ||
| </InputAdornment> |
There was a problem hiding this comment.
Ok, I see the value here. At the beginning I thought we were just going to manage 'password' mode as hardcode. Obviously this makes more sense
| import { IconButton, InputAdornment, TextField } from '@mui/material'; | ||
| import { VisibilityOffOutlined, VisibilityOutlined } from '@mui/icons-material'; | ||
|
|
||
| const PasswordField = forwardRef(({ style, ...otherProps }, ref) => { |
There was a problem hiding this comment.
Why do you extract here 'style' vs 'otherProps'
There was a problem hiding this comment.
you are right, is not needed. Removed!
packages/react-ui/src/types.d.ts
Outdated
| @@ -219,3 +219,8 @@ type TooltipDataProps = { | |||
| ]; | |||
| title?: string; | |||
| }; | |||
|
|
|||
| // PasswordField | |||
| export interface PasswordFieldProps { | |||
There was a problem hiding this comment.
do we really need to declare this interface, couldn't we just allow same TextField props?
There was a problem hiding this comment.
See this custom TextField here: https://mui.com/material-ui/react-text-field/#customization (eg RedditTextField). It basically passes down all props, using TextFieldProps .
What do you think?
There was a problem hiding this comment.
yes, totally, removed.
There was a problem hiding this comment.
I also cleaned up Button, which had the same unnecessary interface.
Description
Shortcut: #268673
[sc-268673]