Check null value to avoid crash on category widget #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #239960: [ac_pbwqze2p] CARTO 3 User's Category Widget Breaking on Search. |
Clebal
reviewed
Jun 27, 2022
Comment on lines
274
to
275
| elem.name !== null && | ||
| (elem.name?.toLowerCase().indexOf(searchValue.toLowerCase()) !== -1 || |
There was a problem hiding this comment.
I would include also !== undefined and by that way you can avoid the optional chaining after name.
Pull Request Test Coverage Report for Build 2575083100
💛 - Coveralls |
Clebal
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/239960/ac-pbwqze2p-carto-3-user-s-category-widget-breaking-on-search
We've encountered that there is an issue with category widgets. The whole application crashes if we use this widget filtering a column that contains null values.
Type of change
Acceptance
Basic checklist