Check null value to avoid crash on category widget (#439)

CartoDB · Jun 28, 2022 · 8fb5ac1 · 8fb5ac1
1 parent 665172d
commit 8fb5ac1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Not released
 
+- Fix CategoryWidget search if there are null values [#439](https://github.com/CartoDB/carto-react/pull/439)
 - Layout improvements in BarWidgetUI [#438](https://github.com/CartoDB/carto-react/pull/438)
 - Fix FormulaWidget column check [#437](https://github.com/CartoDB/carto-react/pull/437)
 

diff --git a/packages/react-ui/src/widgets/CategoryWidgetUI.js b/packages/react-ui/src/widgets/CategoryWidgetUI.js
@@ -271,11 +271,14 @@ function CategoryWidgetUI(props) {
         return searchValue
           ? list.filter((elem) => {
               return (
-                elem.name.toLowerCase().indexOf(searchValue.toLowerCase()) !== -1 ||
-                (labels[elem.name]
-                  ? labels[elem.name].toLowerCase().indexOf(searchValue.toLowerCase()) !==
-                    -1
-                  : false)
+                elem.name !== null &&
+                elem.name !== undefined &&
+                (elem.name.toLowerCase().indexOf(searchValue.toLowerCase()) !== -1 ||
+                  (labels[elem.name]
+                    ? labels[elem.name]
+                        .toLowerCase()
+                        .indexOf(searchValue.toLowerCase()) !== -1
+                    : false))
               );
             })
           : list;
@@ -614,7 +617,8 @@ CategoryWidgetUI.defaultProps = {
 CategoryWidgetUI.propTypes = {
   data: PropTypes.arrayOf(
     PropTypes.shape({
-      name: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.bool]).isRequired,
+      name: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.bool])
+        .isRequired,
       value: PropTypes.number
     })
   ),