Add Global mode to TimeSeriesWidget #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Víctor Velarde <victor.velarde@gmail.com>
|
This pull request has been linked to Shortcut Story #219452: TimeSeriesWidget - global (remote) mode. |
…sc-219452/timeserieswidget-global-remote-mode
Pull Request Test Coverage Report for Build 2196645397
💛 - Coveralls |
| DAYS = 'days', | ||
| HOURS = 'hours', | ||
| MINUTES = 'minutes' | ||
| YEARS = 'year', |
There was a problem hiding this comment.
Out of curiosity, why this change?
There was a problem hiding this comment.
Because in all the providers, these operations are singular :(
Comment on lines
122
to
125
| value: | ||
| value.filter((_, idx) => idx % 2 === 0).reduce((acc, [val]) => acc + val, 0) / | ||
| value.filter((_, idx) => idx % 2 !== 0).reduce((acc, [val]) => acc + val, 0) | ||
| })); |
There was a problem hiding this comment.
This final part is a bit obscure, can you comment (or use some better variable names)?
There was a problem hiding this comment.
I agree. I'm going to improve it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.