Add Global mode to CategoryWidget & PieWidget #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #219449: CategoryWidget & PieWidget - global (remote) mode. |
Josmorsot
reviewed
Apr 18, 2022
| : formatOperationColumn(operationColumn || column, joinOperation) | ||
| }) as value`; | ||
|
|
||
| return `SELECT COALESCE(${column}, 'null') as name, ${selectValueClause} FROM ${formatTableNameWithFilters( |
There was a problem hiding this comment.
Just to confirm, what databases should support this feature?
There was a problem hiding this comment.
Any of them. Do you know any incompatibility here?
There was a problem hiding this comment.
Nop, but it would be nice to involve Data team in these queries verification. Can you gather them (not just this one) and pass them to @Jesus89 please?
| @@ -10,7 +10,7 @@ export default function useWidgetFetch( | |||
| { id, dataSource, params, global, onError } | |||
| ) { | |||
| // State | |||
| const [data, setData] = useState(null); | |||
| const [data, setData] = useState(); | |||
There was a problem hiding this comment.
Why this change here Sergio?
There was a problem hiding this comment.
As you can see in that line, we define a default value. A default value can only be assigned in destructuring when it's undefined, not null.
VictorVelarde
approved these changes
Apr 18, 2022
added 4 commits
April 19, 2022 10:11
… of github.com:CartoDB/carto-react into feature/sc-219449/categorywidget-piewidget-global-remote-mode
… of github.com:CartoDB/carto-react into feature/sc-219449/categorywidget-piewidget-global-remote-mode
4a6fbdb
into
feature/sc-219448/formulawidget-remote-mode-for-global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.