Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing property 'googleMapId' #294

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Add missing property 'googleMapId' #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
421d9e6
add missing property 'googleMapId'
Josmorsot Jan 21, 2022
53f6095
add changelog entry
Josmorsot Jan 21, 2022
ca82bea
Merge branch 'master' into missing-properties-initial-state
Josmorsot Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Align legend icon with its label [#300](https://github.com/CartoDB/carto-react/pull/300)
- Align legend expand icon with title [#299](https://github.com/CartoDB/carto-react/pull/299)
- Use LegendComponent in LegendWidgetUI as JSX component to avoid react errors [#295](https://github.com/CartoDB/carto-react/pull/295)
- Add missing property (`googleMapId`) to `InitialCarto2State` [#294](https://github.com/CartoDB/carto-react/pull/294)
Josmorsot marked this conversation as resolved.
Show resolved Hide resolved
- Improve styles for MaterialUI Dialog component [#272](https://github.com/CartoDB/carto-react/pull/272)
- Add and export CartoTheme type that describe our custom theme [#298](https://github.com/CartoDB/carto-react/pull/298)

Expand Down
1 change: 1 addition & 0 deletions packages/react-redux/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ export {
InitialOauthState,
OauthState,
ViewState,
InitialCarto3State,
} from './types';
1 change: 1 addition & 0 deletions packages/react-redux/src/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type InitialCarto2State = {
basemap: CartoBasemapsNames,
credentials: Credentials,
googleApiKey: string,
googleMapId: string,
}

type OauthCarto3 = {
Expand Down