Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing property 'googleMapId' #294

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Add missing property 'googleMapId' #294

merged 3 commits into from
Jan 24, 2022

Conversation

Josmorsot
Copy link
Contributor

Description

Shortcut: (link)

Removing oauth section from initialStateSlice, in @carto/cra-template-base-3-typescript, cause an error in ProtectedRoute. We have to update template adding properly type to initialStateSlice but first we need to update the InitialCarto2State to include googleMapId.

Type of change

  • Fix

@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1739680663

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.415%
Totals Coverage Status
Change from base Build 1739649600: 0.0%
Covered Lines: 1155
Relevant Lines: 1544
💛 - Coveralls

@Josmorsot Josmorsot force-pushed the missing-properties-initial-state branch from ff5988b to 424f2b7 Compare January 21, 2022 08:27
@Josmorsot Josmorsot mentioned this pull request Jan 21, 2022
Merged
@Josmorsot Josmorsot force-pushed the missing-properties-initial-state branch from 424f2b7 to 90fb9f5 Compare January 21, 2022 11:22
@Josmorsot Josmorsot force-pushed the missing-properties-initial-state branch from 90fb9f5 to 53f6095 Compare January 24, 2022 11:47
VictorVelarde
VictorVelarde approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Josmorsot Josmorsot merged commit be36bb3 into master Jan 24, 2022
@Josmorsot Josmorsot deleted the missing-properties-initial-state branch January 24, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padawannn padawannn padawannn approved these changes

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Josmorsot @coveralls @VictorVelarde @padawannn