Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scatter plot widget & deck.gl update to alpha 10 #149

Merged
merged 24 commits into from
Jun 17, 2021
Merged

Add Scatter plot widget & deck.gl update to alpha 10 #149

merged 24 commits into from
Jun 17, 2021

Conversation

VictorVelarde
Copy link
Contributor

@VictorVelarde VictorVelarde commented Jun 8, 2021 •
edited
Loading

This is a sample integration within react-template

image

@VictorVelarde VictorVelarde changed the base branch from master to carto-cloud-native June 8, 2021 18:00
@VictorVelarde
Remove unused import
bd56e6e
@VictorVelarde
Remove SQL queries from ScatterPlotModel
af983de 
This way it will work the same as the rest of models (eg HistogramModel), without a dependency on SQL API and working purely based on viewportFeatures
@VictorVelarde VictorVelarde changed the base branch from carto-cloud-native to master June 14, 2021 15:52
@VictorVelarde VictorVelarde changed the base branch from master to carto-cloud-native June 14, 2021 15:53
@VictorVelarde
Copy link
Contributor Author

THIS SHOULD BE PUT IN SYNC WITH MASTER

@VictorVelarde VictorVelarde changed the title Add Scatter plot widget adapted to CN Add Scatter plot widget Jun 15, 2021
@VictorVelarde VictorVelarde changed the base branch from carto-cloud-native to master June 15, 2021 18:43
@VictorVelarde VictorVelarde changed the title Add Scatter plot widget Add Scatter plot widget & deck.gl update to alpha 10 Jun 15, 2021
@coveralls
Copy link
Collaborator

coveralls commented Jun 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 940438385

  • 27 of 35 (77.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 76.973%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/ScatterPlotWidgetUI.js 14 22 63.64%
Totals Coverage Status
Change from base Build 936498762: -0.8%
Covered Lines: 610
Relevant Lines: 748
💛 - Coveralls

@VictorVelarde VictorVelarde requested a review from alasarr June 15, 2021 19:15
@VictorVelarde VictorVelarde merged commit 6ed0760 into master Jun 17, 2021
@VictorVelarde VictorVelarde mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alasarr alasarr Awaiting requested review from alasarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VictorVelarde @coveralls @alasarr @AdriSolid @jtmiclat