Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScatterPlotWidget #129

Closed
wants to merge 1 commit into from
Closed

Add ScatterPlotWidget #129

wants to merge 1 commit into from

Conversation

jtmiclat
Copy link
Contributor

Add a Scatter Plot Widget

Demo
scatterplotwidget

Since the addition of workers, all Widgets stories are broken. Widget UI stories still work.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 675413562

  • 38 of 46 (82.61%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 78.078%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/ScatterPlotWidgetUI.js 15 23 65.22%
Totals Coverage Status
Change from base Build 668689666: -0.6%
Covered Lines: 607
Relevant Lines: 734
💛 - Coveralls

@VictorVelarde
Copy link
Contributor

Thx for the contribution @jtmiclat. We'll check it in detail soon. It looks really nice! 👍🏻

@VictorVelarde VictorVelarde self-requested a review March 22, 2021 15:54
@VictorVelarde
Copy link
Contributor

This PR was adapted and its work was merged to master in #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtmiclat @coveralls @VictorVelarde