-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim Some Dependencies #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eave it to the pixi.toml
…t available until post-activation
…llow non-pixi building
…fter local sys deps install
Zolkin1
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. All my questions were answered in code. Verified main repo, example repo, and person downstream repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #73.
uv
andnvm
as system-level dependencies installed bydocker_setup.sh
.PYRIGHT_PYTHON_FORCE_VERSION
,RCUTILS_COLORIZED_OUTPUT
, andRMW_IMPLEMENTATION
environment variables into thepixi.toml
to preventbashrc
pollution.~/.bashrc
and into the~/.bash_aliases
file to reduce pollutionsource-obelisk
task, which didn't do what we wanted to. Now, introduces a newobk-build
alias that properly builds and sources the obelisk packages in the correct order. Works both in and out of a pixi shell!libyaml-dev
as a dep~/.gitconfig
and~/.ssh
into Docker containers so end user can develop properly (outside the .devcontainer context)install_sys_deps.sh
scriptobk-clean
alias that cleans out the build/install/log dirs of obelisk_wsobk
command that sets environment variables in the current shell. Also builds Obelisk if it's not already built. MOST IMPORTANT NEW ADDITION!/opt/ros/humble/setup.bash
exists when runningobk
Unanswered questions:
TODOs: