Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim Some Dependencies #74

Merged
merged 46 commits into from
Jul 22, 2024
Merged

Trim Some Dependencies #74

merged 46 commits into from
Jul 22, 2024

Conversation

alberthli
Copy link
Contributor

@alberthli alberthli commented Jul 21, 2024

This PR closes #73.

  • Removes uv and nvm as system-level dependencies installed by docker_setup.sh.
  • Moves PYRIGHT_PYTHON_FORCE_VERSION, RCUTILS_COLORIZED_OUTPUT, and RMW_IMPLEMENTATION environment variables into the pixi.toml to prevent bashrc pollution.
  • Moves obelisk aliases out of the ~/.bashrc and into the ~/.bash_aliases file to reduce pollution
  • Removes the source-obelisk task, which didn't do what we wanted to. Now, introduces a new obk-build alias that properly builds and sources the obelisk packages in the correct order. Works both in and out of a pixi shell!
  • Removes libyaml-dev as a dep
  • Mount ~/.gitconfig and ~/.ssh into Docker containers so end user can develop properly (outside the .devcontainer context)
  • Add a Docker compose file specifically for CI (doesn't do ssh stuff)
  • Adds the ability to do pixi-free building of the obelisk packages via the install_sys_deps.sh script
  • Modifies the setup scripts such that any local changes made to system are always opt-in
  • Update README with information on how to set up, build, and use Obelisk
  • Added obk-clean alias that cleans out the build/install/log dirs of obelisk_ws
  • remove cuda 11.8 dep set from pixi
  • Sets up obk command that sets environment variables in the current shell. Also builds Obelisk if it's not already built. MOST IMPORTANT NEW ADDITION!
    • source base ros if not in a conda or a pixi environment and /opt/ros/humble/setup.bash exists when running obk

Unanswered questions:

  • Are there issues with building obelisk via pixi and then sourcing it in downstream projects? Need to evaluate in a future example.

TODOs:

  • update docs

alberthli added 30 commits July 20, 2024 17:22
@alberthli alberthli marked this pull request as ready for review July 22, 2024 06:23
@alberthli alberthli requested a review from Zolkin1 July 22, 2024 06:24
Copy link
Collaborator

@Zolkin1 Zolkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. All my questions were answered in code. Verified main repo, example repo, and person downstream repo.

@alberthli alberthli merged commit 78acc6b into main Jul 22, 2024
1 check passed
@alberthli alberthli deleted the trim-deps branch July 22, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim System-Level Deps and Minimize System/~/.bashrc Pollution with Setup Scripts
2 participants