refactor: remove dependency cycles to fix eslint errors #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caleydo/cohort#693 - Replace `Cohort` with `ICohort` were possible - Add interfaces `IInputCohort` and `IOutputCohort` - Move classes `InputCohort` and `OutputCohort` to Cohort.ts - Move public functions and properties from `Cohort` to interface `ICohort` - Move interfaces and enums from `Cohort` to app/interfacoes - Replace `Array<...>` with `...[]` syntax
17 tasks
* Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * Release 4.1.0 (#54) * prepare next dev version * Fix colors assignment in plots (#41) * Prepare github changes * Remove circleci * prepare next dev version * Use `Font Awesome 6 Free` in `font-family` (#39) * Use `Font Awesome 6 Free` in `font-family` Requires datavisyn/tdp_core#732 * Update Lineup to 4.6.2 Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at> * Update fontawesome * Merge visyn_scripts * prepare next dev version * Merged `d3_changes` into `develop` (#45) * use d3v7 and d3v3 imports remove depenencies to d3 add dependency to tdp_core * remove console log * Dev d3 merge fix (#47) * move RouterScrollToTop to coral_public * fix TS errors * move canvas-confetti to coral_public * update git dependencies Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at> * Automatically select root cohort if onboarding was already done (#48) * Autoselect rootcohort if onboarding was done #579 * format code * Remove grid lines from visualizations (#49) remove gridlines #400 * Upgrade python deps (#51) * Upgrade python deps * Switch back to #develop * prepare release 4.1.0 --------- Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at> Co-authored-by: anita-steiner <> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Patrick <42137747+PatrickAdelberger@users.noreply.github.com> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com> * prepare next dev version * Migration to visyn_core (#55) * Migration to visyn_core * Linting * Upgrade deps --------- Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io> * Fix cohort * Fix circular dependencies * Further cleanup * Fix async in loop * Import * Add todos for async inside loop errors --------- Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com> Co-authored-by: Vanessa Stoiber <52395160+dvvanessastoiber@users.noreply.github.com> Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Patrick <42137747+PatrickAdelberger@users.noreply.github.com> Co-authored-by: dvvanessastoiber <vanessa.stoiber@datavisyn.io> Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
| .on('click', (event, d: IDataSubtypeConfig) => { | ||
| const badgeName = this._composeGeneDataTypeName(data.optionText, d.name); | ||
| .html((v: IDataSubtypeConfig) => v.name) | ||
| .on('click', (event, v: IDataSubtypeConfig) => { |
There was a problem hiding this comment.
v.name is not available, so access it from the d.name from the above context.
This needed an after fix as the eslint suggestion caused a bug.
oltionchampari
approved these changes
May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Caleydo/cohort#693
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor) to this PR following semverCloses #...)Summary of changes
ICohortinstead ofCohort)Screenshots
Additional notes for the reviewer(s)
Thanks for creating this pull request 🤗