Skip to content

Commit

Permalink
refactor: remove dependency cycles to fix eslint errors (#50)
Browse files Browse the repository at this point in the history
* Remove `|| true` to show eslint errors

#693

* Run `lint:fix` to automatically fix formatting

#693

* Add missing component `RouterScrollToTop`

* Refactor src/app.ts into separate files src/app/*

Caleydo/cohort#693

* Rename app/Cohort to app/Coral

* Move colors to config/colors

Caleydo/cohort#693

* Move rest to base/rest

Caleydo/cohort#693

* Move ScrollLinker from util file to utils/ScrollLinker

Caleydo/cohort#693

* Remove unused color schemes

Caleydo/cohort#693

* Extract CohortColorSchema from util to separate file

Caleydo/cohort#693

* Merge CohortColorSchema with config/colors

Caleydo/cohort#693

* Move utilCustomEvents to base/events

Caleydo/cohort#693

* Move utilIdTypes to config/entities

Caleydo/cohort#693

* Move utilLabels to utils/labels

Caleydo/cohort#693

* Merge Tooltip into AColumn and remove export

Caleydo/cohort#693

* Rename event to event2 for nested event

Caleydo/cohort#693

* Merge CohortInterfaces into app/interfaces

Caleydo/cohort#693

* Use `ICohort` instead `Cohort`

Caleydo/cohort#693

- Replace `Cohort` with `ICohort` were possible
- Add interfaces `IInputCohort` and `IOutputCohort`
- Move classes `InputCohort` and `OutputCohort` to Cohort.ts
- Move public functions and properties from `Cohort` to interface `ICohort`
- Move interfaces and enums from `Cohort` to app/interfacoes
- Replace `Array<...>` with `...[]` syntax

* Reorder functions in utlis/labels

Caleydo/cohort#693

* Eslint and typescript errors (#56)

* Upgrade python deps (#51)

* Upgrade python deps

* Switch back to #develop

* Release 4.1.0 (#54)

* prepare next dev version

* Fix colors assignment in plots (#41)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Use `Font Awesome 6 Free` in `font-family` (#39)

* Use `Font Awesome 6 Free` in `font-family`

Requires datavisyn/tdp_core#732

* Update Lineup to 4.6.2

Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at>

* Update fontawesome

* Merge visyn_scripts

* prepare next dev version

* Merged `d3_changes` into `develop`  (#45)

* use d3v7 and d3v3 imports
remove depenencies to d3
add dependency to tdp_core

* remove console log

* Dev d3 merge fix (#47)

* move RouterScrollToTop to coral_public

* fix TS errors

* move canvas-confetti to coral_public

* update git dependencies

Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at>

* Automatically select root cohort if onboarding was already done (#48)

* Autoselect rootcohort if onboarding was done #579

* format code

* Remove grid lines from visualizations (#49)

remove gridlines #400

* Upgrade python deps (#51)

* Upgrade python deps

* Switch back to #develop

* prepare release 4.1.0

---------

Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at>
Co-authored-by: anita-steiner <>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Patrick <42137747+PatrickAdelberger@users.noreply.github.com>
Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>

* prepare next dev version

* Migration to visyn_core (#55)

* Migration to visyn_core

* Linting

* Upgrade deps

---------

Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>

* Fix cohort

* Fix circular dependencies

* Further cleanup

* Fix async in loop

* Import

* Add todos for async inside loop errors

---------

Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
Co-authored-by: Vanessa Stoiber <52395160+dvvanessastoiber@users.noreply.github.com>
Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Patrick <42137747+PatrickAdelberger@users.noreply.github.com>
Co-authored-by: dvvanessastoiber <vanessa.stoiber@datavisyn.io>
Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>

* bug: merge data subtype object

* Fix client config typings

---------

Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
Co-authored-by: Vanessa Stoiber <52395160+dvvanessastoiber@users.noreply.github.com>
Co-authored-by: Klaus Eckelt <Klaus.Eckelt@jku.at>
Co-authored-by: Patrick <42137747+PatrickAdelberger@users.noreply.github.com>
Co-authored-by: dvvanessastoiber <vanessa.stoiber@datavisyn.io>
Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
  • Loading branch information
9 people authored May 15, 2023
1 parent 45937d5 commit c65c9cb
Show file tree
Hide file tree
Showing 68 changed files with 2,690 additions and 2,549 deletions.
2 changes: 1 addition & 1 deletion .eslintcache

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"dist": "mkdir lib && cd dist && tar cvzf ../lib/bundle.tar.gz *",
"docs": "visyn_scripts docs",
"lint:fix": "visyn_scripts lint --fix",
"lint": "visyn_scripts lint || true",
"lint": "visyn_scripts lint",
"prepack": "yarn run build",
"start": "visyn_scripts start --env workspace_mode=single",
"storybook:build": "NODE_OPTIONS=--max_old_space_size=4096 build-storybook",
Expand Down
Loading

0 comments on commit c65c9cb

Please sign in to comment.