Graphql tooling #166
Merged
Graphql tooling #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
erikbosch
reviewed
Jun 7, 2022
erikbosch
reviewed
Jun 7, 2022
|
@danielwilms rebase and fix comments, then ready to merge Decision to merge 2022/06/07 |
Tooling for creating a graphql schema based on vspec files.
- moved tool to contrib - rename script as alternative - adoptions to new tools version
`Source` and `channel` weren't described properly. This commit adds documentation for those fields, as proposed by @ericbosch. VSS `uint32` was mapped to `GraphQLInt`, which wasn't sufficient. Now changed to `GraphQLFloat`. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
3bdd81f to
41f71ef
Compare
|
@erikbosch, rebased, fixed typo and added the link to the documentation |
|
@erikbosch, please wait with merging. found one bug still |
- adopt graphql to use exporters
- remove additional fields `source` and `channel`
- add graphql specific parameter to add additional metadata
- adopt readme
- remove graphql exporters from contrib
call with:
```
${TOOLSDIR}/vspec2graphql.py -I ./spec --gqlfield "source" "Source System" --gqlfield "channel" "Collecting channel" ./spec/VehicleSignalSpecification.vspec vss_rel_$$(cat VERSION).graphql.ts
```
Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
41f71ef to
eda0549
Compare
Should be fine now...please run it once on your machine (you just have to remove |
|
Did a sanity check and it worked fine. Merging it. I assume next step for you is to update Makefile in VSS and update submodule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade of graphql as community supported tool