Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSS to DDS-IDL exporter inclusion in make file #455

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

zam1kor
Copy link
Contributor

@zam1kor zam1kor commented Jun 8, 2022

No description provided.

@erikbosch
Copy link
Collaborator

I triggered the build. (For first time contributors builds must be triggered manually by someone with write/admin rights). The build fails - the vss-tools submodule needs to be updated so that the Python file is available for the build. That could however possibly be synched with the GraphQL change as they also will need to change the Makefile.

Suggestion: @danielwilms - if you first update VSS Makefile and submodule reference to handle the changes in COVESA/vss-tools#166, then @zam1kor does not need to update submodule reference. I.e. first integrate the GraphQL changes, then the DDSIDL changes

./vss-tools/vspec2ddsidl.py -I ./spec ./spec/VehicleSignalSpecification.vspec vss_rel_$(cat VERSION).idl	
/bin/sh: 1: ./vss-tools/vspec2ddsidl.py: not found
make: *** [Makefile:40: ddsidl] Error 127
Error: Process completed with exit code 2.

@danielwilms
Copy link
Collaborator

@erikbosch, will do!

@erikbosch erikbosch force-pushed the feature/vss2idl_exporter branch from e8f82a1 to cf13d98 Compare June 14, 2022 09:17
@erikbosch
Copy link
Collaborator

Trivial PR, so I consider that no discussion on the weekly meetings is needed. Build now passes. Will merge it.

@erikbosch erikbosch merged commit b289cdf into COVESA:master Jun 14, 2022
@erikbosch erikbosch deleted the feature/vss2idl_exporter branch September 29, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants