Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identification extension (LicensePlate and VehicleExteriorColor) #619

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Identification extension (LicensePlate and VehicleExteriorColor) #619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
290c9cc
added VehicleIdentification.LicensePlate
jakubdrabik Jun 6, 2023
1d3c894
added VehicleIdentification.VehicleExteriorColor
jakubdrabik Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions spec/Vehicle/Vehicle.vspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ VehicleIdentification.DateVehicleFirstRegistered:
type: attribute
description: The date in ISO 8601 format of the first registration of the vehicle with the respective public authorities.

VehicleIdentification.LicensePlate:
datatype: string
type: attribute
description: The license plate of the vehicle.
comment: Depending on the context, this attribute might not be up to date or might be misconfigured, and therefore should be considered untrustworthy in the absence of another method of verification.

VehicleIdentification.MeetsEmissionStandard:
datatype: string
type: attribute
Expand Down Expand Up @@ -136,6 +142,11 @@ VehicleIdentification.VehicleSpecialUsage:
type: attribute
description: Indicates whether the vehicle has been used for special purposes, like commercial rental, driving school.

VehicleIdentification.VehicleExteriorColor:
Copy link
Collaborator

@erikbosch erikbosch Jun 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to more explicit on what we expect this signal to contain, for example stating that it shall be the OEM name of the color, rather than internal/standardized color code, and that the names used are not standardized? For example, a possible name could be "Carnelian red metallic".

(I by the way do not know if there is any international standard color scheme for vehicle colors. In the Swedish vehicle registry there are only 24 colors to choose from, like light red, red and dark red, but I assume that varies from country to country)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience, there's usually a need to have a basic colour palette which serves as easy identification, especially towards users and for comparative reasons across different brands/models. Something you could find in the Vehicle Registration Certificate (at least the European one), however, there's no standard set of those colours and it differs per country as far as I know.

This attribute (VehicleExteriorColor) is meant to represent this basic set of colours (blue, black, red, white, ...).

"Carnelian red metallic" are rather marketing names (could be VehicleExteriorColorName) that refer to specific colour codes of an OEM (could be VehicleExteriorColorCode).

Does that make sense?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll provide a better description of the property

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we have both option, one with fancy name from OEM and second as basic pallet which you might find in vehicle license?

datatype: string
type: attribute
description: The main color of the exterior within the basic color palette (eg. red, blue, black, white, ...).

VehicleIdentification.VehicleInteriorColor:
datatype: string
type: attribute
Expand Down