-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identification extension (LicensePlate and VehicleExteriorColor) #619
Identification extension (LicensePlate and VehicleExteriorColor) #619
Conversation
@@ -136,6 +141,11 @@ VehicleIdentification.VehicleSpecialUsage: | |||
type: attribute | |||
description: Indicates whether the vehicle has been used for special purposes, like commercial rental, driving school. | |||
|
|||
VehicleIdentification.VehicleExteriorColor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to more explicit on what we expect this signal to contain, for example stating that it shall be the OEM name of the color, rather than internal/standardized color code, and that the names used are not standardized? For example, a possible name could be "Carnelian red metallic".
(I by the way do not know if there is any international standard color scheme for vehicle colors. In the Swedish vehicle registry there are only 24 colors to choose from, like light red, red and dark red, but I assume that varies from country to country)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, there's usually a need to have a basic colour palette which serves as easy identification, especially towards users and for comparative reasons across different brands/models. Something you could find in the Vehicle Registration Certificate (at least the European one), however, there's no standard set of those colours and it differs per country as far as I know.
This attribute (VehicleExteriorColor) is meant to represent this basic set of colours (blue, black, red, white, ...).
"Carnelian red metallic" are rather marketing names (could be VehicleExteriorColorName) that refer to specific colour codes of an OEM (could be VehicleExteriorColorCode).
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll provide a better description of the property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we have both option, one with fancy name from OEM and second as basic pallet which you might find in vehicle license?
ad793d1
to
60e5fbd
Compare
Meeting notes:
|
60e5fbd
to
fe57a27
Compare
@erikbosch @adobekan @nickrbb I dealt with the trailing space and mentioned the license plate risk using the |
Concerning colors there were a meeting chat message asking if we possibly should use colors from https://www.farb-tabelle.de/de/farbtabelle.htm. My personal view is that using those standardized colors does not make sense, as they neither correspond to the colors supported by the vehicle registry, not the OEM marketing name of the color. The Hex/RGB code could possibly be interesting to represent, but I do not know if it would be sufficient for a garage to do a good paint job. By the way, I found the 10 colors used in the german vehicle registry. So a bit fewer than the 24 we have in Sweden: Es stehen insgesamt 10 Farbcodes zur Verfügung, die folgenden Farben zugeordnet werden: 0 = Weiß 1 = Gelb 2 = Orange 3 = Rot 4 = Lila bzw. Violett 5 = Blau 6 = Grün 7 = Grau 8 = Braun 9 = Schwarz |
To give it another perspective, this is the list of options from mobile.de. I used to work on a dealership management system, including one for used cars, and having a standard set of (not just) colours would make life much easier. On the other hand, the market is very inconsistent which might lead to a huge burden to try to standardize the values. |
The issue with the license plate number isn't that it's sensitive (it's displayed on the vehicle in a very prominent and easily readable manner, in most cases) it's that it cannot be trusted as correct. This is because this is something that the OEM cannot set and protect/make read-only (e.g. as they do with the VIN), and the license plate on a vehicle is subject to change (e.g. vehicle owner buys a privatised number plate, US citizen moves to a different state to live), consequently it means someone else other than the OEM has to configure it, and with privately-owned vehicles this is going to have to be the vehicle owner/user. In which case, if some local authorities want to use this signal rather than, say, using automatic number plate recognition (ANPR) technology, then this would be a very bad idea. Note that, in the UK at least, it is a crime to display incorrect number plates (purposefully or accidentally); it is NOT a crime to have an incorrect license plate number configuration within vehicle systems. Please don't misunderstand my concern to be objecting to this proposal, because I am not. I see valid use cases for having this information in vehicles, including privately-owned vehicles e.g. vehicles paying for their parking automatically (in which case, vehicle users are incentivised to configure the right license plate number so that they don't get a fine for parking without paying). But if this data is used for say, congestion charging (e.g. https://www.visitlondon.com/traveller-information/getting-around-london/congestion-charge), then the vehicle user is incentivised to fake it. I hope that conveys my point. As I said, just having some words of warning about this would resolve my issue. We can't stop certain entities (e.g. local authorities) from ultimately misusing it and then finding out people can easily circumvent it, but we can at least warn them. Thus, proposed wording could be something like: Here "another method of verification" could be that a vehicle fleet manager configures this setting and locks it down from being altered in the vehicle itself, which I believe was a use case mentioned on the call yesterday. |
@nickrbb The information might as well be simply out of date. I suggest this:
What do you think? |
I don't understand why you think this is sensitive information (see my explanation as to why I don't think it is in my first paragraph of my posting above). Please can you elaborate? |
Signed-off-by: Jakub Drabik <jakub@fromjimmy.com>
Signed-off-by: Jakub Drabik <jakub@fromjimmy.com>
fe57a27
to
1d3c894
Compare
Even though it's prominent, considering the same system (inside/outside the vehicle) would also keep information about the user, it could potentially lead to risks like privacy invasion etc. However, this is very specific to use cases and probably not a concern of VSS itself. I updated the PR with just the first sentence. |
Looks OK to me now, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Meeting notes:
|
During our adoption of VSS we noticed missing license plate number and vehicle exterior color.
VehicleExteriorColor could further be accompanied by VehicleExteriorColorSpecification with more details.