Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify safe YAML loader, which avoids warning #128

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

gunnarx
Copy link
Contributor

@gunnarx gunnarx commented Oct 30, 2019

This change deals with the warning that was printed before.
(read link for more info):

YAMLLoadWarning: calling yaml.load() without Loader=... is
deprecated, as the default Loader is unsafe. Please read
https://msg.pyyaml.org/load for full details.

Signed-off-by: Gunnar Andersson gandersson@genivi.org

@gunnarx
Copy link
Contributor Author

gunnarx commented Oct 30, 2019

By the way, I checked that the output files (vss_rel_*) were generated identically after running
make, before and after this change.

This change deals with the warning that was printed before.
(read link for more info):

   YAMLLoadWarning: calling yaml.load() without Loader=... is
   deprecated, as the default Loader is unsafe. Please read
   https://msg.pyyaml.org/load for full details.

Signed-off-by: Gunnar Andersson <gandersson@genivi.org>
@UlfBj
Copy link
Contributor

UlfBj commented Nov 14, 2019

+1

@danielwilms danielwilms self-requested a review November 15, 2019 08:15
@danielwilms danielwilms merged commit 7ce6e1e into COVESA:master Nov 15, 2019
slawr added a commit to slawr/vehicle_signal_specification that referenced this pull request Feb 8, 2022
Update the vss-tools submodule to the current master commit to get
various improvements including the change of 'enum' to 'allowed' in the
rule set.

Submodule vss-tools 579c58f..0894e95:
  > Fixing versioning according to packaging guides
  > Adding FAQ
  > vspec2binary.py enum name replaced by allowed.
  > Binary tool enum name replaced by allowed.
  > [CORE] Move from `enum` to `allowed`
  > Adding support for types listed in vehicle-signal-specification in (COVESA#134)
  > Feature/validate nameing conventions (COVESA#128)
  > [BUILD] Python version updated to 3.8.12
  > [BUILD] Move from `requirements.txt` to `Pipfile`
  > go module version update.
  > Use argparse for YAML generation. Allow optional strict checking (COVESA#117)
  > Removing dead code in csv generator (COVESA#126)
  > Removing obsolete entries from VSS-tools (COVESA#124)

Signed-off-by: Stephen Lawrence <stephen.lawrence@renesas.com>
danielwilms pushed a commit that referenced this pull request Feb 9, 2022
Update the vss-tools submodule to the current master commit to get
various improvements including the change of 'enum' to 'allowed' in the
rule set.

Submodule vss-tools 579c58f..0894e95:
  > Fixing versioning according to packaging guides
  > Adding FAQ
  > vspec2binary.py enum name replaced by allowed.
  > Binary tool enum name replaced by allowed.
  > [CORE] Move from `enum` to `allowed`
  > Adding support for types listed in vehicle-signal-specification in (#134)
  > Feature/validate nameing conventions (#128)
  > [BUILD] Python version updated to 3.8.12
  > [BUILD] Move from `requirements.txt` to `Pipfile`
  > go module version update.
  > Use argparse for YAML generation. Allow optional strict checking (#117)
  > Removing dead code in csv generator (#126)
  > Removing obsolete entries from VSS-tools (#124)

Signed-off-by: Stephen Lawrence <stephen.lawrence@renesas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants