Correctly generates sha256 hashes for all subtrees in a spec #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on name, type, min, max, and enum values. Correctly updates hashes for a modified signal and all its parental branches (up to the root). Added some more checks in the code to ensure correct handling of branches vs. signals. Added signature print example in vss_dump.c
slawr
added a commit
to slawr/vehicle_signal_specification
that referenced
this pull request
Feb 8, 2022
Update the vss-tools submodule to the current master commit to get various improvements including the change of 'enum' to 'allowed' in the rule set. Submodule vss-tools 579c58f..0894e95: > Fixing versioning according to packaging guides > Adding FAQ > vspec2binary.py enum name replaced by allowed. > Binary tool enum name replaced by allowed. > [CORE] Move from `enum` to `allowed` > Adding support for types listed in vehicle-signal-specification in (COVESA#134) > Feature/validate nameing conventions (COVESA#128) > [BUILD] Python version updated to 3.8.12 > [BUILD] Move from `requirements.txt` to `Pipfile` > go module version update. > Use argparse for YAML generation. Allow optional strict checking (COVESA#117) > Removing dead code in csv generator (COVESA#126) > Removing obsolete entries from VSS-tools (COVESA#124) Signed-off-by: Stephen Lawrence <stephen.lawrence@renesas.com>
danielwilms
pushed a commit
that referenced
this pull request
Feb 9, 2022
Update the vss-tools submodule to the current master commit to get various improvements including the change of 'enum' to 'allowed' in the rule set. Submodule vss-tools 579c58f..0894e95: > Fixing versioning according to packaging guides > Adding FAQ > vspec2binary.py enum name replaced by allowed. > Binary tool enum name replaced by allowed. > [CORE] Move from `enum` to `allowed` > Adding support for types listed in vehicle-signal-specification in (#134) > Feature/validate nameing conventions (#128) > [BUILD] Python version updated to 3.8.12 > [BUILD] Move from `requirements.txt` to `Pipfile` > go module version update. > Use argparse for YAML generation. Allow optional strict checking (#117) > Removing dead code in csv generator (#126) > Removing obsolete entries from VSS-tools (#124) Signed-off-by: Stephen Lawrence <stephen.lawrence@renesas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each branch and signal gets a hash based on its own and its children's n name, type, min, max, and enum values.
Correctly updates hashes for a modified signal and all its parental branches (up to the root).
Added some more checks in the code to ensure correct handling of branches vs. signals.
Added signature print example in vss_dump.c