Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with banner notification of both playback and recording devices when switching playback device with a hotkey (and vice versa). #893

Closed
kreis117 opened this issue Mar 26, 2022 · 10 comments
Closed

Issue with banner notification of both playback and recording devices when switching playback device with a hotkey (and vice versa). #893

kreis117 opened this issue Mar 26, 2022 · 10 comments
Labels
Bug Issues which are bug reports Confirmed Confirmed issues released

Comments

@kreis117
Copy link
Contributor

Describe the bug
Issue with banner notification of both playback and recording devices when switching playback device with a hotkey (and vice versa).

Version
SoundSwitch v6.2.4.0

To Reproduce
Steps to reproduce the behavior:

  1. Open the settings screen
  2. With the settings screen active, use hot keys to switch playback devices (or recording devices)
  3. A banner notification for the recording device will appear for a moment, then the banner notification for the playback device will appear.

Expected behavior
Only switched devices will be banner notified.

Screenshots
https://user-images.githubusercontent.com/74777259/160225183-7f6da146-efeb-43f8-894b-c49a6f32f60e.mp4

Additional context
Add any other context about the problem here.
@kreis117 kreis117 added the Bug Issues which are bug reports label Mar 26, 2022
@Belphemur
Copy link
Owner

If both are show, that would mean for Windows both got switched...

This is kind of weird, do you have any other application that interact with audio device ?

@kreis117
Copy link
Contributor Author

kreis117 commented Jun 5, 2022

I don't think I have any other application that interact with audio device.
As noted above, it only seems to happen when the settings window is open.
It also seems to occur with notification methods other than banners.

@felipecrs
Copy link

Glad I'm not the only one. See:

chrome_G91Wppm6jo.mp4

I was only pressing the Playback switch shortcut (not Recording switch shortcut), yet, you can see that it shows up the Recording device almost always.

I'm happy to provide any data that may be useful.

@felipecrs
Copy link

felipecrs commented Dec 23, 2022 •
edited
Loading

BTW the issue persists even after closing Nvidia Broadcast, PowerToys, Logitech G Hub, Nahimic and LogiTune. Disabling Switch Default Communication Device does not seem to help either.

@Belphemur
Copy link
Owner

@felipecrs Are you on Win11 ?

I have the feeling they changed something in the API and give all device when one is changed instead of just the one that changed.

@felipecrs
Copy link

Yes, Windows 11 22H2.

@Belphemur Belphemur added the Confirmed Confirmed issues label Dec 23, 2022
@Belphemur
Copy link
Owner

Belphemur commented Jan 24, 2023 •
edited
Loading

I think I've figured how to fix it.

Can you try a test version for me ?
https://f000.backblazeb2.com/file/SoundSwitch/nightly/SoundSwitch-6.5.39925.1238.zip

This should fix that issue.

Download the zip, stop SoundSwitch, go where SoundSwitch is installed, replace all the file with the content of the Zip and restart SoundSwitch

@felipecrs
Copy link

On it.

@felipecrs
Copy link

felipecrs commented Jan 24, 2023 •
edited
Loading

Awesome, it works just fine!

ItYWJtuAvp.mp4

github-actions bot pushed a commit that referenced this issue Feb 2, 2023
@semantic-release-bot
chore(release): 6.5.1 [skip ci]
b8eee09 
## [6.5.1](v6.5.0...v6.5.1) (2023-02-02)

### Bug Fixes

* **Crash::NoError:** Fix crashing without error ([4d2ee17](4d2ee17))
* **logging:** Make foreground change message verbose ([6c69344](6c69344))
* **Notification::Banner:** Fix double notification (for both playback and recording device) in Win 11 ([a28b70d](a28b70d))
* **Notification::Win11:** Fix double notification ([ed20fd5](ed20fd5)), closes [#893](#893)
* **Profile::Editing:** Fix inability to change the Notify for profile ([0b0cd0c](0b0cd0c)), closes [#1090](#1090)
* **Steam::BigPicture:** Improve detection of steam big picture ([2e7a2af](2e7a2af))
* **Tooltip::Volume:** Be sure the volume of the tooltip is properly shown ([8fc9cc4](8fc9cc4)), closes [#1096](#1096)
* **Tooltip::Volume:** Fix how to show the volume in the tooltip. Start with the volume then name of device. ([9b21dc8](9b21dc8)), closes [#1096](#1096)
* **Volume:** Fix volume calculation ([9b692c8](9b692c8)), closes [#1096](#1096)
* **Window::Name:** Fix possible crash when trying to get the name of a Window ([6b45a50](6b45a50)), closes [#1095](#1095)

### Languages

* **Korean:** Translated Settings using Weblate ([ab0aab7](ab0aab7))

### Enhancements

* **logs:** Improve sentry log message in case of crash ([b1b093e](b1b093e))
* **logs:** Remove unneeded threadid ([8e73936](8e73936))
* **Profile::Form:** Reduce the size of the form to edit/create profile ([7e8c42a](7e8c42a)), closes [#1091](#1091)
* **Profile::Steam:** Improve the detection of Steam Big Picture mode in Windows 11 ([af955f2](af955f2))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

🎉 This issue has been resolved in version 6.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues which are bug reports Confirmed Confirmed issues released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Belphemur @felipecrs @kreis117