fix(Crash::NoError): Fix crashing without error

This should show an error to the user and log the problem properly. Fixes SOUNDSWITCH-BQ Fixes SOUNDSWITCH-BS Fixes SOUNDSWITCH-BR
Belphemur · Feb 2, 2023 · 4d2ee17 · 4d2ee17
1 parent 1e2f2fd
commit 4d2ee17
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/SoundSwitch/Program.cs b/SoundSwitch/Program.cs
@@ -202,13 +202,7 @@ private static void HandleException(Exception exception)
             if (exception == null)
                 return;
 
-            SentryId eventId = default;
-            SentrySdk.WithScope(scope =>
-                {
-                    scope.AddAttachment(AppConfigs.Configuration.FileLocation);
-                    eventId = SentrySdk.CaptureException(exception);
-                }
-            );
+            var eventId = SentrySdk.CaptureException(exception, scope => { scope.AddAttachment(AppConfigs.Configuration.FileLocation); });
 
             var exceptionMessage = exception.Message;
             if (exception.InnerException != null)
@@ -224,10 +218,25 @@ private static void HandleException(Exception exception)
 Would you like to share more information with the developers?";
             var result = DialogResult.None;
             var syncContext = _synchronizationContext ?? SynchronizationContext.Current;
-            syncContext.Send(state =>
+            syncContext?.Send(state =>
             {
-                result = MessageBox.Show(message, $@"{Application.ProductName} crashed...", MessageBoxButtons.YesNo,
-                    MessageBoxIcon.Error);
+                try
+                {
+                    try
+                    {
+                        result = MessageBox.Show(message, $@"{Application.ProductName} crashed...", MessageBoxButtons.YesNo,
+                            MessageBoxIcon.Error);
+                    }
+                    catch (InvalidOperationException)
+                    {
+                        result = MessageBox.Show(message, $@"{Application.ProductName} crashed...", MessageBoxButtons.YesNo,
+                            MessageBoxIcon.Error, MessageBoxDefaultButton.Button1, MessageBoxOptions.ServiceNotification);
+                    }
+                }
+                catch (Exception)
+                {
+                    Log.Warning("Couldn't warn the user about the crash");
+                }
             }, null);