V23develop merge to master

.clang-format.base → .clang-format

@@ -1,10 +1,10 @@
 ---
 BasedOnStyle: Webkit
-Language:        Cpp
+Language: Cpp
 SpaceBeforeParens: Always
 SpaceAfterTemplateKeyword: true
-Standard:        Cpp11
-TabWidth:        4
+Standard: Cpp11
+TabWidth: 4
 IndentWidth: 4
 PointerAlignment: Middle
 UseTab: ForContinuationAndIndentation
@@ -15,9 +15,9 @@ AllowShortCaseLabelsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: false
 AllowShortLambdasOnASingleLine: All
 AllowShortLoopsOnASingleLine: false
-BreakConstructorInitializersBeforeComma: true
 BreakConstructorInitializers: AfterColon
 ConstructorInitializerAllOnOneLineOrOnePerLine: false
+ConstructorInitializerIndentWidth: 4
 ContinuationIndentWidth: 0
 KeepEmptyLinesAtTheStartOfBlocks: false
 IndentCaseLabels: true
@@ -34,7 +34,6 @@ BraceWrapping:
   AfterClass: true
   BeforeCatch: true
   BeforeElse: true
-  BeforeLambdaBody: true
   SplitEmptyRecord: true
   SplitEmptyNamespace: true
 SortIncludes: true

.github/ISSUE_TEMPLATE.md

@@ -1,79 +1,19 @@
 <!--
 
 ---------------------------------------------------
-HAVE A QUESTION? PLEASE JOIN OUR DISCORD SERVER
+PLEASE USE PRE-SET ISSUE TEMPLATES
 ---------------------------------------------------
 
-Only use GitHub issues for reporting problems and submitting proposals. 
+To help better qualify new issues the preference is for the pre-set templates to be used
+instead of this blank issue. Please go back or visit https://github.com/nanocurrency/nano-node/issues/new/choose
+and use one of the following templates:
 
-Questions should  be asked on our Discord server, https://chat.nano.org,
-which has channels for a wide range of topics, such as development and 
-support.
-
----------------------------------------------------
-BUG BOUNTY REPORT INFORMATION
----------------------------------------------------
-
-In the interest of further improving the security of the network, we have launched the Nano Bug Bounty Program.
-
-WARNING! Don't disclose any information for the Nano bug.
-
-Submit any suspected bugs for bounty consideration to bugs@nano.org.
-
----------------------------------------------------
-NORMAL BUG REPORT INFORMATION
----------------------------------------------------
-
-If you are reporting a new issue, make sure that we do not have any duplicates
-already open. You can ensure this by searching the issue list for this
-repository. If there is a duplicate, please close your issue and add a comment
-to the existing issue instead.
-
-If you suspect your issue is a bug, please edit your issue description to
-include the BUG REPORT INFORMATION shown below. If you fail to provide this
-information within 7 days, we cannot debug your issue and will close it. We
-will, however, reopen it if you later provide the information.
-
--->
-
-**Description of bug:**
-
-<!--
-Does this issue reproduce with the latest release? if you don't use the latest version then please try our latest version.
+Request a new node feature
+Report a node/protocol issue
+Report a security vulnerability
 
-Briefly describe the problem you are having in a few paragraphs. 
--->
-
-**Steps to reproduce the issue:**
-1.
-2.
-3.
-
-**Describe the results you received:**
-
-
-**Describe the results you expected:**
-
-
-**Additional information you deem important (e.g. issue happens only occasionally):**
-
-**Environment**:
-
-<!--
-- OS information  
-- (Linux) Kernel (e.g. `uname -a`):
-- Node version
-- (docker node) docker version 
--->
-
-**logs**
-
-<!--
-
-Can you please provide the Nano logs for further analysis.
-
-How to find Nano logs:
-
-https://github.com/nanocurrency/nano-node/wiki/Log-files
+Questions should be asked on our Discord server, https://chat.nano.org, or Forum, https://forum.nano.org,
+which have channels for a wide range of topics, such as development and 
+support.
 
 -->

.github/ISSUE_TEMPLATE/config.yml

@@ -1,4 +1,4 @@
-blank_issues_enabled: false
+blank_issues_enabled: true
 contact_links:
   - name: Report a security vulnerability
     url: https://docs.nano.org/node-implementation/contributing/#security-vulnerability-disclosure

.github/workflows/analyzers.yml

@@ -4,23 +4,19 @@ on: [push, pull_request]
 
 jobs:
   clang_format:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
     steps:
       - uses: actions/checkout@50fbc622fc4ef5163becd7fab6573eac35f8462e
-      - name: Installing clang-format 10
+      - name: Installing clang-format 12
         env:
           DEBIAN_FRONTEND: noninteractive
-        run: sudo apt-get install clang-format-10
-      - name: Setting clang-format 10 as the default
-        env:
-          DEBIAN_FRONTEND: noninteractive
-        run: sudo update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-10 1000
-      - name: Clang Format
-        run: ci/check-commit-format.sh
+        run: sudo apt-get install clang-format-12
+      - name: Check clang-format
+        run: ci/clang-format-check.sh
 
   cmake_format:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
     steps:
       - uses: actions/checkout@50fbc622fc4ef5163becd7fab6573eac35f8462e
@@ -33,4 +29,4 @@ jobs:
           packages: |
             cmake-format
       - name: Check cmake-format
-        run: bash ci/check-cmake-format.sh
+        run: ci/cmake-format-check.sh

.github/workflows/beta_artifacts.yml

@@ -16,7 +16,7 @@ env:
 
 jobs:
   osx_job:
-    runs-on: macos-latest
+    runs-on: macOS-10.15
     timeout-minutes: 90
     env:
       BOOST_ROOT: /tmp/boost
@@ -41,7 +41,7 @@ jobs:
           AWS_DEFAULT_REGION: us-east-2
 
   linux_job:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     timeout-minutes: 90
     steps:
       - name: tag
@@ -66,7 +66,7 @@ jobs:
           AWS_DEFAULT_REGION: us-east-2
 
   linux_docker_job:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     timeout-minutes: 90
     steps:
       - name: tag
@@ -118,4 +118,4 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_DEFAULT_REGION: us-east-2
+          AWS_DEFAULT_REGION: us-east-2

.github/workflows/coverage.yml

@@ -0,0 +1,56 @@
+name: Coverage Reports
+
+on:
+  workflow_dispatch:
+    inputs:
+      label:
+        description: "label to append to run"
+        default: "Scheduled"
+        required: true
+  schedule:
+    - cron: "0 1 * * 0"
+jobs:
+  coverage_test:
+    name: Coverage Test [TEST_USE_ROCKSDB=${{ matrix.TEST_USE_ROCKSDB }}]
+    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
+    env:
+      LCOV: 1
+      COMPILER: gcc
+      BOOST_ROOT: /tmp/boost
+    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        TEST_USE_ROCKSDB: [0, 1]
+      fail-fast: false
+    continue-on-error: true
+    timeout-minutes: 60
+    steps:
+      - uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
+        with:
+          submodules: "recursive"
+      - name: Fetch Deps
+        run: |
+          sudo apt-get update -qq && sudo apt-get install -yqq build-essential g++ wget python zlib1g-dev qt5-default \
+          valgrind xorg xvfb xauth xfonts-100dpi xfonts-75dpi xfonts-scalable xfonts-cyrillic ocl-icd-opencl-dev \
+          git lcov python3-pip
+          util/build_prep/fetch_boost.sh
+          wget -O cmake_install.sh https://github.com/Kitware/CMake/releases/download/v3.15.4/cmake-3.15.4-Linux-x86_64.sh
+          chmod +x cmake_install.sh
+          sudo ./cmake_install.sh --prefix=/usr --exclude-subdir --skip-license
+      - name: Build and Test
+        env:
+          TEST_USE_ROCKSDB: ${{ matrix.TEST_USE_ROCKSDB }}
+        run: ./ci/build-travis.sh /usr/lib/x86_64-linux=gnu/cmake/Qt5
+      - uses: coverallsapp/github-action@8cbef1dea373ebce56de0a14c68d6267baa10b44
+        with:
+          github-token: ${{ secrets.github_token }}
+          flag-name: rocksdb-${{ matrix.TEST_USE_ROCKSDB }},${{ github.event.inputs.label }}
+          parallel: true
+  finish:
+    needs: coverage_test
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: coverallsapp/github-action@8cbef1dea373ebce56de0a14c68d6267baa10b44
+        with:
+          github-token: ${{ secrets.github_token }}
+          parallel-finished: true

.github/workflows/develop.yml

@@ -3,10 +3,10 @@ name: Develop
 on:
   push:
     branches:
-      - develop  
+      - develop
 jobs:
   linux_job:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
         with:
@@ -24,4 +24,4 @@ jobs:
       - name: Deploy Docker (nanocurrency/nano-env)
         run: ci/actions/linux/deploy-docker.sh
         env:
-          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}

.github/workflows/live_artifacts.yml

@@ -15,7 +15,7 @@ env:
 
 jobs:
   osx_job:
-    runs-on: macos-latest
+    runs-on: macOS-10.15
     timeout-minutes: 90
     env:
       BOOST_ROOT: /tmp/boost
@@ -40,7 +40,7 @@ jobs:
           AWS_DEFAULT_REGION: us-east-2
 
   linux_job:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     timeout-minutes: 90
     steps:
       - name: tag
@@ -65,7 +65,7 @@ jobs:
           AWS_DEFAULT_REGION: us-east-2
 
   linux_docker_job:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     timeout-minutes: 90
     steps:
       - name: tag
@@ -117,4 +117,4 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_DEFAULT_REGION: us-east-2
+          AWS_DEFAULT_REGION: us-east-2