V23develop merge to master #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CI, just convenient at times (nanocurrency#3407)
…_ref Converting sever static initializations of nano::network_params to references
…nce to network_params.
* fixes regression allowing for networks to honor build and runtime selection * clang-format
… process and remove the subsequently unused instance of nano::network_params that was instantiated statically.
…uffer to using channel::send
…ssary. Serializing this version number to/from the message_header the same as the other two version_max and version_using.
…erencing it statically.
…r than on message header construction. This separates the assignment of protocol-specific information, specifically the version numbers, from the logic of creating messages.
…atically instantiated dev network params with the version available in the nano::dev namespace.
…instantiation of network parameters to test if a state block is an epoch.
…c information to determine network.
…work_constants in order to eliminate guesswork of setting these values before serializing.
…_ref Removing static initialization of nano::network_params
…s path are no longer supported in the upgrade path. (nanocurrency#3414)
* Remove qt_system target we dont need it or use it * cmake format sanitization
…stantiating statically.
…o nanocurrency-develop
…a.bin as 'ours' in the merge strategy
) It makes it difficult/impossible to access election objects in unit tests and it increases complexity for no obvious benefit. This change could potentially fix a lot of unit test race conditions. Fixes nanocurrency#3584 and probably many other unit tests.
) (#33) It makes it difficult/impossible to access election objects in unit tests and it increases complexity for no obvious benefit. This change could potentially fix a lot of unit test race conditions. Fixes nanocurrency#3584 and probably many other unit tests. Co-authored-by: dsiganos <dimitris@siganos.org>
We are getting complaints that nodes are hitting this limit. We do not think it is really a problem but we are increasing this limit to see if the warnings stop. These complaints could be diverting focus away from the real problems. max_peers_per_ip was 5 and now it is 10 max_peers_per_subnet was 20 and now it is 40
Noted by @RickiNano on beta-testing that not clear outcome of election (confirmed or dropped) by reviewing logs. Added true/false to log string. Co-authored-by: RickiNano
…e into nanocurrency-releases/v23
…e into nanocurrency-releases/v23
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.