Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several plot methods and fixed a few minor bugs/warnings #262

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 7, 2024

Issues addressed by this PR

Closes #261

See commit message.

Test files

See changes to pytest files for examples of use of the newly added methods. Bug fixes mainly regarded fixing methods which raised warnings about deprecation.

Changelog

Additional comments

@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:bug Error or unexpected behaviour type:feature New capability or enhancement priority:low Resources should be targeted to other issues first labels Nov 7, 2024
@tg359 tg359 self-assigned this Nov 7, 2024
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of missing docstrings, and the utci comparison plot has a formatting issue. I have tested everything that has been changed, and these are the only issues I have come across.

@tg359 tg359 requested a review from Tom-Kingstone November 18, 2024 14:48
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything again (as well as new stuff added since last comment), and formatting of plots is all fixed now, though there are still some issues with unit tests, and a logic issue with the tilt orientation factor plot method.

@tg359 tg359 requested a review from Tom-Kingstone December 5, 2024 09:49
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 5, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 48 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Dec 5, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

There are 2 requests in the queue ahead of you.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing, new issue created to fix bhom/wrapped method and plots created are looking good.

Maybe need another issue for recreating the solar class (unless it's already raised), but happy to merge this as is.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Dec 5, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check unit-tests

There are 58 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 5, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@tg359 tg359 merged commit b36d379 into develop Dec 5, 2024
13 checks passed
@tg359 tg359 deleted the LadybugTools_Toolkit-#261-AdditionalPlotMethods branch December 5, 2024 14:30
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Resources should be targeted to other issues first severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more plotting methods
3 participants