-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added several plot methods and fixed a few minor bugs/warnings #262
Added several plot methods and fixed a few minor bugs/warnings #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of missing docstrings, and the utci comparison plot has a formatting issue. I have tested everything that has been changed, and these are the only issues I have come across.
LadybugTools_Engine/Python/src/ladybugtools_toolkit/plot/_seasonality.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested everything again (as well as new stuff added since last comment), and formatting of plots is all fixed now, though there are still some issues with unit tests, and a logic issue with the tilt orientation factor plot method.
LadybugTools_Engine/Python/src/ladybugtools_toolkit/categorical/categorical.py
Outdated
Show resolved
Hide resolved
LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/comfort_feasibility.py
Outdated
Show resolved
Hide resolved
@Tom-Kingstone to confirm, the following actions are now queued:
There are 48 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are passing, new issue created to fix bhom/wrapped method and plots created are looking good.
Maybe need another issue for recreating the solar class (unless it's already raised), but happy to merge this as is.
@Tom-Kingstone to confirm, the following actions are now queued:
There are 58 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #261
See commit message.
Test files
See changes to pytest files for examples of use of the newly added methods. Bug fixes mainly regarded fixing methods which raised warnings about deprecation.
Changelog
Additional comments