Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bhom/wrapped: Update directional_solar_radiation python and C# methods to align with other adapter execute actions #273

Closed
Tom-Kingstone opened this issue Dec 5, 2024 · 0 comments · Fixed by #283
Closed

bhom/wrapped: Update directional_solar_radiation python and C# methods to align with other adapter execute actions #273

Tom-Kingstone opened this issue Dec 5, 2024 · 0 comments · Fixed by #283
Assignees
@Tom-Kingstone
Labels
type:feature New capability or enhancement

Comments

@Tom-Kingstone
Copy link
Contributor

Description:

Align so that this method returns a PlotInformation object, and the input object needs to change to align with the changes to plot_tilt_orientation_factor()
@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Dec 5, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Dec 5, 2024
@Tom-Kingstone Tom-Kingstone changed the title Update directional_solar_radiation python and C# methods to align with other adapter execute actions bhom/wrapped: Update directional_solar_radiation python and C# methods to align with other adapter execute actions Dec 5, 2024
Tom-Kingstone added a commit that referenced this issue Dec 5, 2024
@Tom-Kingstone
make bhom/wrapped method throw notimplemented. added issue to fix in #…
a61491f 
…273
@Tom-Kingstone Tom-Kingstone mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add solar radiation plot to adapter actions BHoM/LadybugTools_Toolkit
1 participant
@Tom-Kingstone