Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated required pollination version to 1.46.0 #192

Merged
merged 4 commits into from
May 10, 2024
Merged

Updated required pollination version to 1.46.0 #192

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5362c3
updated required pollination version to 1.46.0
Tom-Kingstone Apr 19, 2024
f7dc30c
fix unit test fail on radiance, namespace was changed for a method fr…
Tom-Kingstone Apr 29, 2024
9d96c6a
fixed quote marks around post build commands
Tom-Kingstone May 10, 2024
5d4a253
also fixed issue on robocopy command
Tom-Kingstone May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...bugTools_Engine/Python/src/ladybugtools_toolkit/honeybee_extension/simulation/radiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from honeybee_radiance_command.options.rfluxmtx import RfluxmtxOptions
from honeybee_radiance_command.options.rpict import RpictOptions
from honeybee_radiance_command.options.rtrace import RtraceOptions
from honeybee_radiance_postprocess.results import _filter_grids_by_pattern
from honeybee_radiance_postprocess.util import _filter_grids_by_pattern
from ladybug.analysisperiod import AnalysisPeriod
from ladybug.wea import Wea
from ladybug_geometry.geometry3d import Plane, Point3D
Expand Down
2 changes: 1 addition & 1 deletion LadybugTools_Engine/Python/src/ladybugtools_toolkit/ladybug_extension/datacollection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def collection_from_series(series: pd.Series) -> BaseCollection:
header.metadata["source"] = "From custom pd.Series"

freq = pd.infer_freq(series.index)
if freq in ["H"]:
if freq in ["H", "h"]:
if series.index.is_leap_year.any():
if len(series.index) != 8784:
raise ValueError(
Expand Down
2 changes: 1 addition & 1 deletion LadybugTools_Engine/Query/IsPollinationInstalled.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static partial class Query
[Description("Return True if Pollination is installed to the currently supported version.")]
[Input("targetPollinationVersion", "The target Pollination version that BHoM currently supports.")]
[Output("bool", "True if Pollination is installed to the currently supported version.")]
public static bool IsPollinationInstalled(string targetPollinationVersion = "1.35.14")
public static bool IsPollinationInstalled(string targetPollinationVersion = "1.46.0")
{
// check if referenced Python is installed
string referencedExecutable = System.Environment.GetFolderPath(System.Environment.SpecialFolder.ProgramFiles) + @"\ladybug_tools\python\python.exe";
Expand Down