Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated required pollination version to 1.46.0 #192

Merged
merged 4 commits into from
May 10, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #191

updated required pollination version to 1.46.0, and made change to fix issue caused by the upgrade.

Test files

LBT_Plots.zip

Changelog

  • Updated required Pollination version to 1.46.0

Additional comments

The test file provided gives a general cover of what a user might expect (component/grasshopper-wise), though more thorough testing will be required throughout the following milestone

@Tom-Kingstone Tom-Kingstone added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Apr 19, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Apr 19, 2024
@Tom-Kingstone Tom-Kingstone linked an issue Apr 19, 2024 that may be closed by this pull request
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 19, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Apr 19, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

There are 8 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 22, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check unit-tests

There are 21 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title updated required pollination version to 1.46.0 Updated required pollination version to 1.46.0 Apr 23, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Apr 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 30, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check unit-tests

There are 2 requests in the queue ahead of you.

tg359
tg359 previously approved these changes May 10, 2024
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these changes on my machine and they don't cause an issue - everything working as expected.

@Tom-Kingstone Tom-Kingstone requested a review from tg359 May 10, 2024 13:32
Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed and tested using previous scripts. All working fine.

Note: When running psychometrics, warning "FutureWarning: 'H' is deprecated and will be removed in a future version, please use 'h' instead." appears.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented May 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

There are 7 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented May 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check unit-tests

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 58ddcf6 into develop May 10, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#191-UpdatePollination branch May 10, 2024 14:39
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pollination requirement to 1.46
4 participants