-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null-check for request before checking SelectedItem on global search #676
Add null-check for request before checking SelectedItem on global search #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reason why a null check would be a problem here. Approved!
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @adecler - can't see this hurting anything. But I look forward to being proved wrong in 3 weeks time...
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #675
Adding simple null-check on request before trying to access SelectedItem.
See issue as to why/when this has been slightly annoying issue.
Test files
Global search should still work.
Changelog
Additional comments
Cannot really see how this could have a negative impact on anything, but glad for a quick look @adecler