Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-check for request before checking SelectedItem on global search #676

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #675

Adding simple null-check on request before trying to access SelectedItem.
See issue as to why/when this has been slightly annoying issue.

Test files

Global search should still work.

Changelog

Additional comments

Cannot really see how this could have a negative impact on anything, but glad for a quick look @adecler

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Jan 23, 2023
@IsakNaslundBh IsakNaslundBh requested a review from adecler January 23, 2023 09:10
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 23, 2023
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason why a null check would be a problem here. Approved!

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @adecler - can't see this hurting anything. But I look forward to being proved wrong in 3 weeks time...

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 09219c5 into develop Jan 23, 2023
@IsakNaslundBh IsakNaslundBh deleted the Grasshopper_UI-#675-AddNullCheckForRequestSelectedItemOnGlobalSearch branch January 23, 2023 10:11
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop crash on global search when request is null
3 participants