Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop crash on global search when request is null #675

Closed
IsakNaslundBh opened this issue Jan 23, 2023 · 0 comments · Fixed by #676
Closed

Stop crash on global search when request is null #675

IsakNaslundBh opened this issue Jan 23, 2023 · 0 comments · Fixed by #676
Assignees
Labels
severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

When debugging in Grasshopper, quite often the code crashes (non-fatally) on

else if (request.SelectedItem is CustomItem)

due to the request being null.

Need to add a null-check in this method for the request.

Can be slightly annoying for debugging as this can happen when you have any repository attached, as long as you have built Grasshopper yourself.

Should not be critical for production code as the whole segment is in a try-catch block, but null check should be beneficial anyway.

Steps to reproduce:

Build Grasshopper_UI
Attach any BHoM solution to Grasshopper (does not have to be Grasshopper)
Use grasshopper, dragging some wires etc.
For me it relatively frequently crashes out on this line.

Expected behaviour:

For the null-request to be checked for and handled

Test file(s):

Happens on all files for me, no test file hence required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants