Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Grasshopper_Toolkit -> Grasshopper_UI #660

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Rename Grasshopper_Toolkit -> Grasshopper_UI #660

merged 1 commit into from
Jul 4, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Related to

BHoM/Excel_UI#348

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jul 4, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 4, 2022
@FraserGreenroyd FraserGreenroyd mentioned this pull request Jul 4, 2022
Merged
@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review July 4, 2022 09:53
alelom
alelom approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code changes review only.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 7 requests in the queue ahead of you.

adecler
adecler approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code changes review only.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Dynamo_UI

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, core, null-handling, serialisation, versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 83b024e into main Jul 4, 2022
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#247-RenameToUI branch July 4, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@alelom alelom alelom approved these changes

@pawelbaran pawelbaran Awaiting requested review from pawelbaran

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FraserGreenroyd @alelom @adecler