-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Excel_Toolkit -> Excel_UI #348
Conversation
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 2 requests in the queue ahead of you. |
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 7179677836 |
@FraserGreenroyd I have queued up your request to fix the |
@FraserGreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
The check |
The check |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok overall and compiles without issues.
Just one issue with the namespace (see comment)
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 15 requests in the queue ahead of you. |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 3 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, core, null-handling, serialisation, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the basis of code changes only.
Issues addressed by this PR
Fixes #347
Fixes #349
Test files
Changelog
Additional comments