BHoM_Engine: rounding issues fixed

[pawelbaran]

Issues addressed by this PR

Closes #3426
Closes #3429

Test files

On SharePoint, UTs added

Changelog

Additional comments

So far we had just one method, RoundWithTolerance, which did round the numbers towards the floor regardless of sign, i.e. 121 rounded to 2 would yield 120 and equally, -121 rounded to 2 would yield -120. This is potentially ambiguous on 2 levels:

• the name does not indicate the value is rounded to floor
• rounding to floor is not consistent with what general rounding does, i.e. rounding to floor should always return lower value from the 2 candidates (floor and ceiling) regardless of sign (so -121 should return -122)

As a remedy I propose 3 separate methods that follow the standard rounding conventions:

• RoundToFloor
• Round
• RoundToCeiling

I believe this is a right move for the general audience, although I understand you may need the current implementation for diffing @alelom - if so, I'd suggest moving it to Diffing_Engine as a private method. Let's catch up on that 👍

[pawelbaran]

@BHoMBot check compliance
@BHoMBot check installer
@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check installer
• check versioning

[alelom]

Tested with BHoM/DiffingTests_Prototypes#22 and agreed the change with @pawelbaran.

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

FAO: @adecler @pawelbaran @IsakNaslundBh
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 32526179440

[pawelbaran]

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check unit-tests
• check dataset-compliance

[pawelbaran]

Dispensating documentation compliance as it is out of scope of this PR

[pawelbaran]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 32526179440

[bhombot-ci]

@pawelbaran I have now provided a passing check on reference 32526179440 as requested.

[pawelbaran]

@BHoMBot check copyright-compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check copyright-compliance

There are 7 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check ready-to-merge