Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_Engine: RoundWithTolerance method is misleading #3426

Closed
pawelbaran opened this issue Nov 4, 2024 · 0 comments · Fixed by #3430
Closed

BHoM_Engine: RoundWithTolerance method is misleading #3426

pawelbaran opened this issue Nov 4, 2024 · 0 comments · Fixed by #3430
Assignees
@pawelbaran
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

Description:

As in the title, RoundWithTolerance is misleading because what it actually does is rounding to floor. My suggestion is to rename it to RoundToFloor, to make space to just Round and RoundToCeiling.

FYI @alelom @IsakNaslundBh @al-fisher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BHoM_Engine: rounding issues fixed BHoM/BHoM_Engine
1 participant
@pawelbaran