Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Add engine methods for retaining wall classes #3408

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Aug 29, 2024

NOTE: Depends on

BHoM/BHoM#1621

Issues addressed by this PR

Closes BHoM_Structure_oM

Test files

See.
BHoM/BHoM#1621

Changelog

Added required extension methods for implemented interfaces for new retaining wall classes.

  • Added Geometry() method for Stem and RetainingWall
  • Added IsNull() method for Stem and RetainingWall
  • Added SolidVolume() method for Stem and RetainingWall
  • Added MaterialComposition() method for Stem and RetainingWall
  • Added SetOutlineElements(List<IElement1D> outlineElements1D) method for Stem
  • Added OutlineElemets1D() method for Stem
  • Added Geometry3D() method for Stem and RetainingWall
  • Migrated IsQuad, IsTriangular, IsRectangular, IsSquare to the Geometry namespace so that it can be used on PolyCurves - the methods in BH.Engine.Analytical are unchanged, and just reference the Geometry methods.

Additional comments

HasMargeablePropertiesWith(IElement2D) has not been added for any of the objects in reference to:
#3138 (comment)

…ne methods whereby PadFoundation changed inheritance to IRegion from IElement2D.
@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Aug 29, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Aug 29, 2024
@peterjamesnugent peterjamesnugent self-assigned this Aug 29, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check core
@BHoMBot check versioning
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check core
  • check versioning
  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 17 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Aug 29, 2024

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 29, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

There are 2 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent
Copy link
Member Author

Discussed with @IsakNaslundBh. I have reviewed the PR raised by @KalleEdstroem including testing using the test-scripts.

My commits relate to updating the methods because the changes to PadFoundation and Stem making use of IRegion and the versioning required.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments below. Mostly the Volume calculation that is a bit iffy. The Create method comments are not as bad, even if the double check for planarity most likely needs to go.

Structure_Engine/Query/SolidVolume.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
@peterjamesnugent
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check versioning
@BHoMBot check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check versioning
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 30, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 31, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Sep 2, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Sep 2, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Sep 2, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Sep 2, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Sep 2, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Sep 2, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes made and hence happy to approve this PR.

Copy link

bhombot-ci bot commented Sep 3, 2024

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Sep 3, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Sep 3, 2024

@peterjamesnugent just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit 6c2f2b8 into develop Sep 3, 2024
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Structure_oM-#1619-AddRetainingWallClasses branch September 3, 2024 09:05
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_oM: Add classes for retaining walls.
3 participants