-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Add engine methods for retaining wall classes #3408
Structure_Engine: Add engine methods for retaining wall classes #3408
Conversation
…ne methods whereby PadFoundation changed inheritance to IRegion from IElement2D.
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 17 requests in the queue ahead of you. |
The check |
The check |
@peterjamesnugent to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@peterjamesnugent to confirm, the following actions are now queued:
|
Discussed with @IsakNaslundBh. I have reviewed the PR raised by @KalleEdstroem including testing using the test-scripts. My commits relate to updating the methods because the changes to PadFoundation and Stem making use of IRegion and the versioning required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments below. Mostly the Volume calculation that is a bit iffy. The Create method comments are not as bad, even if the double check for planarity most likely needs to go.
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes made and hence happy to approve this PR.
@peterjamesnugent just to let you know, I have provided a |
@peterjamesnugent just to let you know, I have provided a |
@peterjamesnugent just to let you know, I have provided a |
NOTE: Depends on
BHoM/BHoM#1621
Issues addressed by this PR
Closes BHoM_Structure_oM
Test files
See.
BHoM/BHoM#1621
Changelog
Added required extension methods for implemented interfaces for new retaining wall classes.
Geometry()
method forStem
andRetainingWall
IsNull()
method forStem
andRetainingWall
SolidVolume()
method forStem
andRetainingWall
MaterialComposition()
method forStem
andRetainingWall
SetOutlineElements(List<IElement1D> outlineElements1D)
method forStem
OutlineElemets1D()
method forStem
Geometry3D()
method forStem
andRetainingWall
IsQuad
,IsTriangular
,IsRectangular
,IsSquare
to theGeometry
namespace so that it can be used onPolyCurve
s - the methods inBH.Engine.Analytical
are unchanged, and just reference theGeometry
methods.Additional comments
HasMargeablePropertiesWith(IElement2D)
has not been added for any of the objects in reference to:#3138 (comment)