Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_oM: Add classes for retaining wall objects #1621

Merged
merged 29 commits into from
Sep 3, 2024

Conversation

KalleEdstroem
Copy link
Contributor

@KalleEdstroem KalleEdstroem commented Jul 3, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #1619
Closes #1634

Added definition for retaining wall objects

  • RetainingWall
  • Stem
  • (making use of already defined PadFoundation as a footing)

Test files

Grasshopper test file.
Flowchart of classes and comments on assumptions.

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM/Structure_oM/%231621-retainingWallObjects?csf=1&web=1&e=who8Qd

Changelog

  • RetainingWall class added in Structure_oM
  • Stem class added in Structure_oM

Additional comments

@KalleEdstroem KalleEdstroem added type:feature New capability or enhancement status:WIP PR in progress and still in draft, not ready for formal review labels Jul 3, 2024
@KalleEdstroem KalleEdstroem self-assigned this Jul 3, 2024
@KalleEdstroem
Copy link
Contributor Author

KalleEdstroem commented Jul 12, 2024

Objects definition and required methods implemented.

Two methods are still WIP and need updates from my side:

  • Geometry3D() for Stem
  • MaterialComposition() for RetainingWall

Regarding the Stem and Geometry3d(). Need to agree if the thicknessBottom and thicknessTop should taper in a pyramid shape or if one side always should be in a plane perpendicular to the XY-plane and one side should be angled. Then it needs to be achieved in the Geometry3D() which is a bit tricky.

The MaterialComposition() needs some work figuring out how to handle the if a ReinforcementDenisty fragment is attached to both either the Stem or Footing and the Higher level object RetainingWall.

@KalleEdstroem
Copy link
Contributor Author

Discussions offline agreed on making the stem into a pyramid shape to start with for Geometry3D() method.

MaterialComposition() Updated and gives correct output. Have one persistent issue with an error message getting dispalyed for when ReinforcementDenisty is used from lower level objects (Stem and Footing).

@KalleEdstroem KalleEdstroem marked this pull request as ready for review July 17, 2024 14:58
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 25, 2024
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some description changes - and I wonder if we sub out Footing for PadFoundation - lets discuss when you're back.

Structure_oM/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
Structure_oM/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
Structure_oM/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
Structure_oM/Elements/RetainingWall.cs Outdated Show resolved Hide resolved
Structure_oM/Elements/Stem.cs Outdated Show resolved Hide resolved
Structure_oM/Elements/Stem.cs Outdated Show resolved Hide resolved
Structure_oM/Elements/Footing.cs Outdated Show resolved Hide resolved
@peterjamesnugent
Copy link
Member

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 25, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent removed the status:WIP PR in progress and still in draft, not ready for formal review label Jul 25, 2024
KalleEdstroem and others added 5 commits July 29, 2024 10:09
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
@peterjamesnugent
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 56 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Aug 29, 2024

@KalleEdstroem just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

Copy link

bhombot-ci bot commented Aug 29, 2024

@KalleEdstroem just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

Copy link

bhombot-ci bot commented Aug 29, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 29, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 28 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Aug 29, 2024

@KalleEdstroem just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

@peterjamesnugent
Copy link
Member

Discussed with @IsakNaslundBh. I have reviewed the PR raised by @KalleEdstroem including testing using the test-scripts.

My commits relate to adding inheritance of IRegion for the Stem and PadFoundation objects and the versioning that results from that.

Copy link

bhombot-ci bot commented Aug 29, 2024

@KalleEdstroem just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

Copy link

bhombot-ci bot commented Aug 29, 2024

@KalleEdstroem just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight comment on the versioning. Especially the ToOld becomes a bit nonsensical without specifying the type. (ToOld is not used anywhere, but if we ever do start using it, We should make sure it is correct)

Structure_oM/Versioning_73.json Outdated Show resolved Hide resolved
Copy link

bhombot-ci bot commented Aug 30, 2024

@KalleEdstroem just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

Copy link

bhombot-ci bot commented Sep 2, 2024

@KalleEdstroem just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

Copy link

bhombot-ci bot commented Sep 2, 2024

@KalleEdstroem just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Engine

@peterjamesnugent
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Sep 3, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after updates to the versioning

@peterjamesnugent
Copy link
Member

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Sep 3, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 9 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 3, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit b14e037 into develop Sep 3, 2024
10 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Structure_oM-#1619-AddRetainingWallClasses branch September 3, 2024 09:05
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inheritance of IRegion for PadFoundation Structure_oM: Add classes for retaining walls.
4 participants