-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_oM: Add classes for retaining wall objects #1621
Structure_oM: Add classes for retaining wall objects #1621
Conversation
Objects definition and required methods implemented. Two methods are still WIP and need updates from my side:
Regarding the The |
Discussions offline agreed on making the stem into a pyramid shape to start with for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some description changes - and I wonder if we sub out Footing
for PadFoundation
- lets discuss when you're back.
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 56 requests in the queue ahead of you. |
@KalleEdstroem just to let you know, I have provided a |
@KalleEdstroem just to let you know, I have provided a |
The check |
The check |
@BHoMBot check copyright-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 28 requests in the queue ahead of you. |
@KalleEdstroem just to let you know, I have provided a |
Discussed with @IsakNaslundBh. I have reviewed the PR raised by @KalleEdstroem including testing using the test-scripts. My commits relate to adding inheritance of |
@KalleEdstroem just to let you know, I have provided a |
@KalleEdstroem just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight comment on the versioning. Especially the ToOld becomes a bit nonsensical without specifying the type. (ToOld is not used anywhere, but if we ever do start using it, We should make sure it is correct)
@KalleEdstroem just to let you know, I have provided a |
@KalleEdstroem just to let you know, I have provided a |
@KalleEdstroem just to let you know, I have provided a |
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after updates to the versioning
@BHoMBot check copyright-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #1619
Closes #1634
Added definition for retaining wall objects
RetainingWall
Stem
PadFoundation
as a footing)Test files
Grasshopper test file.
Flowchart of classes and comments on assumptions.
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM/Structure_oM/%231621-retainingWallObjects?csf=1&web=1&e=who8Qd
Changelog
RetainingWall
class added inStructure_oM
Stem
class added inStructure_oM
Additional comments