-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: NewInternalElementXD moved to Query class #3245
BHoM_Engine: NewInternalElementXD moved to Query class #3245
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check core |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
…2D methods to Query class and folders
ddc529b
to
bbc9fb5
Compare
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check core |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meets the issue and discussion, discussed through with @Tom-Kingstone and everything is looking good for another historic issue closed through a clean up, a nice way to start the year this sprint 😄
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
Issues addressed by this PR
Closes #1572
Moved all occurrences of NewInternalElement2D from
Create
toQuery
as in issue, and deleted methods with ToBeRemoved attributes.Test files
Changelog
Additional comments