Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: NewInternalElementXD moved to Query class #3245

Merged
merged 9 commits into from
Jan 12, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1572

Moved all occurrences of NewInternalElement2D from Create to Query as in issue, and deleted methods with ToBeRemoved attributes.

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Jan 12, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jan 12, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd FraserGreenroyd force-pushed the Spatial_Engine-#1572-MoveOrDeleteIElementXD branch from ddc529b to bbc9fb5 Compare January 12, 2024 15:33
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets the issue and discussion, discussed through with @Tom-Kingstone and everything is looking good for another historic issue closed through a clean up, a nice way to start the year this sprint 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 34e6d0c into develop Jan 12, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Spatial_Engine-#1572-MoveOrDeleteIElementXD branch January 12, 2024 17:06
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
@FraserGreenroyd FraserGreenroyd changed the title NewInternalElementXD moved to Query class BHoM_Engine: NewInternalElementXD moved to Query class Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial_Engine: Create NewElement1D etc. should be Query methods
2 participants