Skip to content

Commit

Permalink
NewInternalElementXD moved to Query class (#3245)
Browse files Browse the repository at this point in the history
  • Loading branch information
Fraser Greenroyd authored Jan 12, 2024
2 parents bf89233 + a996b53 commit 34e6d0c
Show file tree
Hide file tree
Showing 13 changed files with 27 additions and 369 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

namespace BH.Engine.Analytical
{
public static partial class Create
public static partial class Query
{
/***************************************************/
/**** Public Methods ****/
Expand All @@ -41,6 +41,7 @@ public static partial class Create
"Method required for any IElement2D that contians internal IElement2Ds.")]
[Input("panel", "Panel just used to determine the appropriate type of IElement2D to create.")]
[Output("opening", "The created Opening as a IElement2D.")]
[PreviousVersion("7.1", "BH.Engine.Analytical.Create.NewInternalElement2D(BH.oM.Analytical.Elements.IPanel<BH.oM.Analytical.Elements.IEdge, BH.oM.Analytical.Elements.IOpening<BH.oM.Analytical.Elements.IEdge>>)")]
public static IElement2D NewInternalElement2D<TEdge, TOpening>(this IPanel<TEdge, TOpening> panel)
where TEdge : IEdge
where TOpening : IOpening<TEdge>
Expand Down
60 changes: 0 additions & 60 deletions Environment_Engine/Create/IElement1D/NewElement1D.cs

This file was deleted.

51 changes: 0 additions & 51 deletions Environment_Engine/Create/IElement2D/NewInternalElement2D.cs

This file was deleted.

80 changes: 0 additions & 80 deletions Environment_Engine/Query/NewElement1D.cs

This file was deleted.

10 changes: 10 additions & 0 deletions Environment_Engine/Versioning_71.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"MessageForDeleted": {
"BH.Engine.Environment.Query.NewElement1D(BH.oM.Environment.Elements.Opening, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
"BH.Engine.Environment.Query.NewElement1D(BH.oM.Environment.Elements.Panel, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
"BH.Engine.Environment.Query.NewElement1D(BH.oM.Environment.Elements.Space, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
"BH.Engine.Environment.Create.NewElement1D(BH.oM.Environment.Elements.Opening, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
"BH.Engine.Environment.Create.NewElement1D(BH.oM.Environment.Elements.Panel, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
"BH.Engine.Environment.Create.NewInternalElement2D(BH.oM.Environment.Elements.Panel)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed."
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

namespace BH.Engine.Geometry
{
public static partial class Create
public static partial class Query
{
/***************************************************/
/**** Public Methods ****/
Expand All @@ -40,6 +40,7 @@ public static partial class Create
"Method required for any IElement2D that contians internal IElement2Ds.")]
[Input("surface", "PlanarSurface just used to determine the appropriate type of IElement2D to create.")]
[Output("opening", "The created Opening as a IElement2D.")]
[PreviousVersion("7.1", "BH.Engine.Geometry.Create.NewInternalElement2D(BH.oM.Geometry.PlanarSurface)")]
public static IElement2D NewInternalElement2D(this PlanarSurface surface)
{
return new PlanarSurface(null, new System.Collections.Generic.List<ICurve>());
Expand Down
69 changes: 0 additions & 69 deletions Physical_Engine/Create/IElement/IElement1D/NewElement1D.cs

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

namespace BH.Engine.Physical
{
public static partial class Create
public static partial class Query
{
/***************************************************/
/**** Public Methods ****/
Expand All @@ -37,6 +37,7 @@ public static partial class Create
[Description("Creates a valid IElement2D which can be assigned as an internal element to the ISurface")]
[Input("surface", "The 2-dimensional element which a valid corresponding internal element is to be gotten from")]
[Output("element2D", "a Void which can be assigned as an internal element to a ISurface")]
[PreviousVersion("7.1", "BH.Engine.Physical.Create.NewInternalElement2D(BH.oM.Physical.Elements.ISurface)")]
public static IElement2D NewInternalElement2D(this oM.Physical.Elements.ISurface surface)
{
Engine.Base.Compute.RecordNote("The ISurface's IOpening may have been modified and replaced, if so the new IOpening has been set as a Void");
Expand Down
6 changes: 6 additions & 0 deletions Physical_Engine/Versioning_71.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"MessageForDeleted": {
"BH.Engine.Physical.Create.NewElement1D(BH.oM.Physical.Elements.ISurface, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed.",
"BH.Engine.Physical.Create.NewElement1D(BH.oM.Physical.Elements.IOpening, BH.oM.Geometry.ICurve)": "NewElement methods were refactored in BHoM 3.2 with these methods marked for deletion, and have now been removed."
}
}
52 changes: 0 additions & 52 deletions Spatial_Engine/Create/NewElement0D.cs

This file was deleted.

Loading

0 comments on commit 34e6d0c

Please sign in to comment.