Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security_Engine: Camera Field of View - cone shape calculation fix #3101

Merged

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3100

Corrected calculation of camera field of view cone shape. This change is to precise the value of horizontal field of view:

Before (HoV = 1000):
image

After (HoV = 1000):
image

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Jul 4, 2023
@michal-pekacki michal-pekacki requested a review from vietle-bh July 4, 2023 14:07
@michal-pekacki michal-pekacki requested a review from al-fisher as a code owner July 4, 2023 14:07
@michal-pekacki michal-pekacki self-assigned this Jul 4, 2023
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests
  • check ready-to-merge

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to ask you what these meant, so let's save future readers the trouble :bowtie:

Security_Engine/Query/ViewCone.cs Outdated Show resolved Hide resolved
Security_Engine/Query/ViewCone.cs Outdated Show resolved Hide resolved
Security_Engine/Query/ViewCone.cs Outdated Show resolved Hide resolved
Security_Engine/Query/ViewCone.cs Outdated Show resolved Hide resolved
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now works as expected 👍

camera test 1

camera test 2

@michal-pekacki
Copy link
Contributor Author

@FraserGreenroyd unit-tests fails somewhere outside of the PR - it would be nice if you can check it

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14786230946

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14786230946

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2023

@FraserGreenroyd I have now provided a passing check on reference 14786230946 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit fa8a87f into develop Jul 5, 2023
@FraserGreenroyd FraserGreenroyd deleted the Security_Engine-#3100-CameraFieldOfViewConeShapeFix branch July 5, 2023 13:27
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security_Engine: Camera Field of View - cone shape calculation
3 participants