-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security_Engine: Camera Field of View - cone shape calculation fix #3101
Security_Engine: Camera Field of View - cone shape calculation fix #3101
Conversation
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
@michal-pekacki to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to ask you what these meant, so let's save future readers the trouble
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
@michal-pekacki to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FraserGreenroyd unit-tests fails somewhere outside of the PR - it would be nice if you can check it |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14786230946 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #3100
Corrected calculation of camera field of view cone shape. This change is to precise the value of horizontal field of view:
Before (HoV = 1000):
After (HoV = 1000):
Test files
Changelog
Additional comments