Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base_Engine: add method to unpack IContainers #3001

Merged
merged 22 commits into from
Feb 28, 2023
Merged

Base_Engine: add method to unpack IContainers #3001

merged 22 commits into from
Feb 28, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Jan 26, 2023

NOTE: Depends on

BHoM/BHoM#1467

Issues addressed by this PR

Closes #3000

Test files

Changelog

Additional comments

@alelom alelom added the type:feature New capability or enhancement label Jan 26, 2023
@alelom alelom self-assigned this Jan 26, 2023
@alelom alelom requested a review from IsakNaslundBh January 26, 2023 12:25
@alelom alelom requested a review from rboulton-BH February 9, 2023 15:54
@alelom alelom mentioned this pull request Feb 10, 2023
Merged
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2023

@FraserGreenroyd I have provided force checks to the checks requested.

FraserGreenroyd
FraserGreenroyd requested changes Feb 20, 2023
View reviewed changes
.ci/code/Verification.sln Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting force checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 20, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@alelom
Copy link
Member Author

alelom commented Feb 22, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 22, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

There are 9 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check null-handling

FraserGreenroyd
FraserGreenroyd approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @IsakNaslundBh review - only unit-tests updated.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 9 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge, code-compliance, documentation-compliance, project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 4f22e6a into develop Feb 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1466-AddIContainerInterface branch February 28, 2023 17:49
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@rboulton-BH rboulton-BH Awaiting requested review from rboulton-BH

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@alelom alelom

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base_Engine: add methods to unpack IContainers
3 participants
@alelom @FraserGreenroyd @IsakNaslundBh