-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Adapter: adding method to unpack objects provided in Push #343
Conversation
6205ed9
to
daa65cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this.
UT works fine, and have also tested with other example object and Robot_Toolkit, which works as expected.
Code changes also makes sense. Approved
@alelom just to let you know, I have provided a |
@alelom just to let you know, I have provided a |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge, project-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM_Engine#3001
Issues addressed by this PR
Closes #341
Closes #177
Test files
See provided test project. We still do not have a concrete class that implements
IContainer
-- a test one is present in the test project.Changelog
Additional comments