Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Adapter: adding method to unpack objects provided in Push #343

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Feb 10, 2023

NOTE: Depends on

BHoM/BHoM_Engine#3001

Issues addressed by this PR

Closes #341
Closes #177

Test files

See provided test project. We still do not have a concrete class that implements IContainer -- a test one is present in the test project.

Changelog

Additional comments

@alelom alelom self-assigned this Feb 10, 2023
@alelom alelom added the type:feature New capability or enhancement label Feb 10, 2023
@alelom alelom force-pushed the BHoM-#1466-AddIContainerInterface branch from 6205ed9 to daa65cc Compare February 21, 2023 09:16
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this.

UT works fine, and have also tested with other example object and Robot_Toolkit, which works as expected.

Code changes also makes sense. Approved

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge, project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 868afb3 into develop Feb 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1466-AddIContainerInterface branch February 28, 2023 17:49
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
3 participants