Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Created a method for SetRegionGeometry #2859

Merged

Conversation

robinflyman
Copy link
Contributor

Closes #2851

Created a new method for SetRegionGeometry.

@robinflyman robinflyman added the type:feature New capability or enhancement label Jun 10, 2022
@robinflyman robinflyman self-assigned this Jun 10, 2022
@robinflyman
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 10, 2022

@robinflyman to confirm, the following checks are now queued:

  • versioning

There are 46 requests in the queue ahead of you.

@rboulton-BH rboulton-BH self-requested a review July 6, 2022 11:50
Copy link
Contributor

@rboulton-BH rboulton-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a model with ~100 spaces and it appears to work correctly based on visual inspection of output. Nice work @robinflyman

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 6, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

There are 15 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 3099407 into main Jul 6, 2022
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2851-NewSetRegionGeometry branch July 6, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: New SetRegionGeometry
3 participants