Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved and renamed Test solution; Test configuration and Build events #346

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Feb 14, 2023

Issues addressed by this PR

Closes #344
Closes #345

Test files

Changelog

Additional comments

@alelom alelom self-assigned this Feb 14, 2023
@alelom alelom added type:feature New capability or enhancement type:compliance Non-conforming to code guidelines labels Feb 14, 2023
@alelom alelom changed the title Moved and Test solution; Test configuration and Build events Moved and renamed Test solution; Test configuration and Build events Feb 14, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - reviewed through @alelom on a code level - meets the requirements following our workshop, happy to merge and unblock @alelom continuing to work for the other PRs while I finish up BHoM/Test_Toolkit#419.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, versioning, core, null-handling, serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd removed the type:feature New capability or enhancement label Feb 14, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11337620666

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 11337620666

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I have now provided a passing check on reference 11337620666 as requested.

@FraserGreenroyd FraserGreenroyd merged commit c2d1d7e into develop Feb 14, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Adapter-#344-RenameTestsSln branch February 14, 2023 17:58
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
2 participants