Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUnit capability #419

Merged
merged 21 commits into from
Feb 16, 2023
Merged

Add NUnit capability #419

merged 21 commits into from
Feb 16, 2023

Conversation

FraserGreenroyd
Copy link

Issues addressed by this PR

Fixes #418

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Feb 14, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Feb 14, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

Please be advised that the check with reference 11329122579 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 36 additional annotations waiting, made up of 36 errors and 0 warnings.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 21 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 11329381789

@FraserGreenroyd
Copy link
Author

@BHoMBot fix copyright headers ref. 11329381789

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 11329433267

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 11329428713

@FraserGreenroyd
Copy link
Author

@BHoMBot fix project file ref. 11329433267

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 14, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@FraserGreenroyd
Copy link
Author

@BHoMBot fix copyright headers ref. 11329428713

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 11360908814

@FraserGreenroyd
Copy link
Author

@BHoMBot fix project file ref. 11360908814

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review February 15, 2023 14:23
Co-authored-by: Alessio Lombardi <alessio.lombardi@burohappold.com>
@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code review, and the development session done with @FraserGreenroyd.

@FraserGreenroyd FraserGreenroyd merged commit 7b4c7b6 into main Feb 16, 2023
@FraserGreenroyd FraserGreenroyd deleted the Test_Toolkit-#418-NUnit branch February 16, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to convert NUnit results into BHoM Framework
3 participants