-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audiences to security token descriptor #2575
Merged
brentschmaltz
merged 75 commits into
dev
from
lozensky/AddAudiencesToSecurityTokenDescriptor
Jun 22, 2024
Merged
Add audiences to security token descriptor #2575
brentschmaltz
merged 75 commits into
dev
from
lozensky/AddAudiencesToSecurityTokenDescriptor
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLozensky
commented
Apr 30, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.CreateToken.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Apr 30, 2024
… Audience and Audiences simultaneously
…andler and JsonWebTokenHandler
JoshLozensky
commented
May 13, 2024
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
keegan-caruso
approved these changes
Jun 17, 2024
keegan-caruso
approved these changes
Jun 18, 2024
JoshLozensky
changed the title
Lozensky/add audiences to security token descriptor
Add audiences to security token descriptor
Jun 19, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.CreateToken.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
…tem without iterating through the entire collection
brentschmaltz
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SecurityTokenDescriptor.Audiences member.
Description
Enabling customers to easily add multiple Audiences to the Aud claim in accordance with the JSON Web Token RFC (7519 section 4.1.3)
Benchmark Results:
The increase in allocation and time taken when using multiple audiences is partly expected, it takes longer to work with multiple strings than a single string.
Fixes #1479