Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityTokenDescriptor Audience is a string, but is should be an array of strings. #1479

Closed
nikosft opened this issue Jun 29, 2020 · 2 comments · Fixed by #2575
Closed

SecurityTokenDescriptor Audience is a string, but is should be an array of strings. #1479

nikosft opened this issue Jun 29, 2020 · 2 comments · Fixed by #2575
Assignees
Labels
Customer reported Indicates issue was opened by customer Enhancement The issue is a new feature IdentityModel8x Future breaking issues/features for IdentityModel 8x P1 More important, prioritize highly
Milestone

Comments

@nikosft
Copy link

nikosft commented Jun 29, 2020

The Audience property of the SecurityTokenDescriptor is of type String. However it should by an array.

Copying pasting from rfc7519 section-4.1

in the general case, the "aud" value is an array of case sensitive strings, each containing a StringOrURI value. In the special case when the JWT has one audience, the "aud" value MAY be a single case-sensitive string containing a StringOrURI value

@brentschmaltz
Copy link
Member

@nikosft yep, we will have to add an API similar to TokenValidationParameters.ValidAudiences as we want to avoid breaking changes.

@brentschmaltz brentschmaltz added Customer reported Indicates issue was opened by customer Enhancement The issue is a new feature P1 More important, prioritize highly labels Jun 29, 2020
@brentschmaltz brentschmaltz added this to the v6 Backlog milestone Jun 29, 2020
@brentschmaltz brentschmaltz changed the title SecurityTokenDescriptor Audience is a sting, but is should be an array of strings. SecurityTokenDescriptor Audience is a string, but is should be an array of strings. Jul 2, 2020
@brentschmaltz brentschmaltz modified the milestones: v6 Backlog, 6.7.3 Jul 27, 2020
@brentschmaltz brentschmaltz modified the milestones: 6.7.3, v6 Backlog Oct 26, 2020
@mafurman mafurman self-assigned this Nov 3, 2020
@brentschmaltz brentschmaltz added the IdentityModel8x Future breaking issues/features for IdentityModel 8x label Mar 30, 2024
@JoshLozensky JoshLozensky self-assigned this Apr 22, 2024
@jmprieur
Copy link
Contributor

Design:

  • Add a new property named "Audiences" of type IList
  • process it in the token creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer reported Indicates issue was opened by customer Enhancement The issue is a new feature IdentityModel8x Future breaking issues/features for IdentityModel 8x P1 More important, prioritize highly
Projects
None yet
5 participants