Reduce allocation with Base64UrlEncoder #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop calling ToCharArray to produce inputs to it; instead pass in a ReadOnlyMemory sliced appropriately - Move the char[] s_base64Table into a u8 span - Use IndexOfAny to determine whether replacements are needed in UnsafeDecode - Stackalloc a span or rent a char[] from the ArrayPool when a temporary is needed in UnsafeDecode
brentschmaltz
approved these changes
Jul 28, 2023
eerhardt
approved these changes
Jul 28, 2023
| @@ -470,25 +469,39 @@ private void ReadToken(string encodedJson) | |||
| throw LogHelper.LogExceptionMessage(new SecurityTokenMalformedException(LogHelper.FormatInvariant(LogMessages.IDX14310, encodedJson))); | |||
|
|
|||
| // right number of dots for JWE | |||
| _hChars = encodedJson.ToCharArray(0, Dot1); | |||
| ReadOnlyMemory<char> hChars = encodedJson.AsMemory(0, Dot1); | |||
There was a problem hiding this comment.
(nit) what does h mean in hChars? "header"?
There was a problem hiding this comment.
No idea, I just kept the original naming :)
| char[] encryptedKeyBytes = encodedJson.ToCharArray(Dot1 + 1, Dot2 - Dot1 - 1); | ||
| if (encryptedKeyBytes.Length != 0) | ||
| ReadOnlyMemory<char> encryptedKeyBytes = encodedJson.AsMemory(Dot1 + 1, Dot2 - Dot1 - 1); | ||
| if (!encryptedKeyBytes.IsEmpty) | ||
| { | ||
| EncryptedKeyBytes = Base64UrlEncoder.UnsafeDecode(encryptedKeyBytes); |
There was a problem hiding this comment.
This is a comment for existing code, but all the other calls to Base64UrlEncoder.UnsafeDecode have a try-catch around them, but this one doesn't. Do we know why?
keegan-caruso
approved these changes
Jul 28, 2023
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
- Stop calling ToCharArray to produce inputs to it; instead pass in a ReadOnlyMemory sliced appropriately - Move the char[] s_base64Table into a u8 span - Use IndexOfAny to determine whether replacements are needed in UnsafeDecode - Stackalloc a span or rent a char[] from the ArrayPool when a temporary is needed in UnsafeDecode
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
- Stop calling ToCharArray to produce inputs to it; instead pass in a ReadOnlyMemory sliced appropriately - Move the char[] s_base64Table into a u8 span - Use IndexOfAny to determine whether replacements are needed in UnsafeDecode - Stackalloc a span or rent a char[] from the ArrayPool when a temporary is needed in UnsafeDecode
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
- Stop calling ToCharArray to produce inputs to it; instead pass in a ReadOnlyMemory sliced appropriately - Move the char[] s_base64Table into a u8 span - Use IndexOfAny to determine whether replacements are needed in UnsafeDecode - Stackalloc a span or rent a char[] from the ArrayPool when a temporary is needed in UnsafeDecode
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
- Stop calling ToCharArray to produce inputs to it; instead pass in a ReadOnlyMemory sliced appropriately - Move the char[] s_base64Table into a u8 span - Use IndexOfAny to determine whether replacements are needed in UnsafeDecode - Stackalloc a span or rent a char[] from the ArrayPool when a temporary is needed in UnsafeDecode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This requires #2158 before it will successfully build and run. It depends on the System.Memory package reference added there for downlevel builds.